Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

On Wed, Apr 30, 2025 at 4:11 PM Mark Dilger wrote: > A similar assertion can still be reached on HEAD using the attached (rather > contrived) regression test as of f60420cff66a9089a9b431f9c07f4a29aae4990a: I independently found the same bug just a few hours ago, using an enhanced version of my p

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

On Mon, Apr 28, 2025 at 9:12 AM Peter Geoghegan wrote: > On Sun, Apr 27, 2025 at 1:06 PM Mark Dilger > wrote: > > I can confirm that your patch fixes the problem, having spent some four > hours trying to find other test cases which still fail, finding none. > > Great. > > I pushed essentially th

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

On Sun, Apr 27, 2025 at 1:06 PM Mark Dilger wrote: > I can confirm that your patch fixes the problem, having spent some four hours > trying to find other test cases which still fail, finding none. Great. I pushed essentially the same patch to HEAD just now. Thanks for the report! -- Peter Geo

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

On Sat, Apr 26, 2025 at 8:53 PM Peter Geoghegan wrote: > On Sat, Apr 26, 2025 at 10:39 PM Mark Dilger > wrote: > > Peter, Matthias, thanks kindly for the good work on skipscans! > > Thanks! > > > I found a test case which fails after commit > 21a152b37f36c9563d1b0b058fe1436baf578b4c. Please fin

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

On Sat, Apr 26, 2025 at 10:39 PM Mark Dilger wrote: > Peter, Matthias, thanks kindly for the good work on skipscans! Thanks! > I found a test case which fails after commit > 21a152b37f36c9563d1b0b058fe1436baf578b4c. Please find a reproducible test > case, attached. The bug isn't actually in

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

Peter, Matthias, thanks kindly for the good work on skipscans! While admiring the recent performance improvements, I found a test case which fails after commit 21a152b37f36c9563d1b0b058fe1436baf578b4c. Please find a reproducible test case, attached. Thanks! On Fri, Apr 4, 2025 at 10:58 AM Pet

pgsql: Improve nbtree skip scan primitive scan scheduling.

Improve nbtree skip scan primitive scan scheduling. Don't allow nbtree scans with skip arrays to end any primitive scan on its first leaf page without giving some consideration to how many times the scan's arrays advanced while changing at least one skip array (though continue not caring about the