Re: pgsql: Initialize unused ExprEvalStep fields.

2018-01-29 Thread Andres Freund
Hi, On 2018-01-29 15:16:59 -0500, Tom Lane wrote: > > Also zero-initialize all scratch ExprEvalStep's allocated on the > > stack, to avoid issues with similar future omissions of non-critial > > data. > > Dunno that that's a good idea; it will also serve to hide valid warnings. Possible, but I t

Re: pgsql: Initialize unused ExprEvalStep fields.

2018-01-29 Thread Tom Lane
Andres Freund writes: > Initialize unused ExprEvalStep fields. > ExecPushExprSlots didn't initialize ExprEvalStep's resvalue/resnull > steps as it didn't use them. That caused wrong valgrind warnings for > an upcoming patch, so zero-intialize. Check ... > Also zero-initialize all scratch ExprEva

pgsql: Initialize unused ExprEvalStep fields.

2018-01-29 Thread Andres Freund
Initialize unused ExprEvalStep fields. ExecPushExprSlots didn't initialize ExprEvalStep's resvalue/resnull steps as it didn't use them. That caused wrong valgrind warnings for an upcoming patch, so zero-intialize. Also zero-initialize all scratch ExprEvalStep's allocated on the stack, to avoid is