Andres Freund writes:
> Obviously that approach could be re-implemented for CI, but givent that it
> additionally is somewhat required to make use of headerscheck/cpluspluscheck
> locally, it feels better to solve it in headerscheck. And the easiest way for
> that seems to be -Werror?
Agreed ---
Hi,
On 2023-02-12 16:25:28 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On February 12, 2023 1:11:08 PM PST, Tom Lane wrote:
> >> I don't think -Werror helps any though; it's a matter of whether the
> >> cfbot is paying attention to headerscheck's exit status ...
>
> > Thomas fixed that p
Andres Freund writes:
> On February 12, 2023 1:11:08 PM PST, Tom Lane wrote:
>> I don't think -Werror helps any though; it's a matter of whether the
>> cfbot is paying attention to headerscheck's exit status ...
> Thomas fixed that part a while ago, but it'll just return 0 if it just is a
> war
Hi,
On February 12, 2023 1:11:08 PM PST, Tom Lane wrote:
>Andres Freund writes:
>> Cfbot didn't catch this, because it only triggered a warning, not a failure.
>> We probably should add -Werror?
>
>Yeah -- nobody is going to go digging through cfbot logs for warnings,
>especially when they kn
Andres Freund writes:
> Cfbot didn't catch this, because it only triggered a warning, not a failure.
> We probably should add -Werror?
Yeah -- nobody is going to go digging through cfbot logs for warnings,
especially when they know that the Compiler Warnings task is supposed
to complain about t
Hi,
On February 12, 2023 10:06:55 AM PST, Tom Lane wrote:
>Make pg_bsd_indent's .h files inclusion-order-safe.
>
>As-is, they failed headerscheck. Per buildfarm.
Cfbot didn't catch this, because it only triggered a warning, not a failure.
We probably should add -Werror?
Greetings,
Andres
Make pg_bsd_indent's .h files inclusion-order-safe.
As-is, they failed headerscheck. Per buildfarm.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/6ded4a5a3de1e8d5f3ec50efd4a2d7a39d2550a6
Modified Files
--
src/tools/pg_bsd_indent/indent.h | 2 ++
1 fil
