Re: pgsql: Modified files for MERGE

2018-04-02 Thread Pavan Deolasee
On Tue, Apr 3, 2018 at 2:06 AM, Andres Freund wrote: > > This seems to have turned several animals red: > - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm= > thrips&dt=2018-04-02%2020%3A27%3A28 > use of uint, which isn't a portable type. > Right. > - https://buildfarm.postgresql.org

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Peter Geoghegan
On Mon, Apr 2, 2018 at 1:59 PM, Simon Riggs wrote: > I diagnosed the causal issue as lack of sleep and will try again once > that is cured. I noticed in passing that the grammar description wasn't updated in merge.sgml after I added WITH clause support. I suppose I should have thought of that, bu

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
On 2 April 2018 at 21:54, Andres Freund wrote: > Hi, > > On 2018-04-02 21:50:28 +0100, Simon Riggs wrote: >> I didn't think it mattered, but clearly does. Reverted before you >> asked. > > I don't think the BF failures were related to the split, though... I > personally think it's fair to take a c

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Andres Freund
Hi, On 2018-04-02 21:50:28 +0100, Simon Riggs wrote: > I didn't think it mattered, but clearly does. Reverted before you > asked. I don't think the BF failures were related to the split, though... I personally think it's fair to take a couple hours to attempt to mop-up post commit issues of a lar

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
On 2 April 2018 at 21:36, Andres Freund wrote: > Hi, > > On 2018-04-02 20:13:41 +, Simon Riggs wrote: >> Modified files for MERGE > > This is a bit of a weird split. What's the reason behind it? Lack of tea, it appears. I didn't think it mattered, but clearly does. Reverted before you asked.

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Peter Geoghegan
On Mon, Apr 2, 2018 at 1:36 PM, Andres Freund wrote: > - > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2018-04-02%2020%3A20%3A01 > looks like copy/read/out/equalfuncs aren't properly filled out A COPY_PARSE_PLAN_TREES run of the regression test seems like a good id

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Andres Freund
Hi, On 2018-04-02 20:13:41 +, Simon Riggs wrote: > Modified files for MERGE This is a bit of a weird split. What's the reason behind it? This seems to have turned several animals red: - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thrips&dt=2018-04-02%2020%3A27%3A28 use of uin

pgsql: Modified files for MERGE

2018-04-02 Thread Simon Riggs
Modified files for MERGE Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/354f13855e6381d288dfaa52bcd4f2cb0fd4a5eb Modified Files -- contrib/test_decoding/expected/ddl.out| 46 contrib/test_decoding/sql/ddl.sql | 16 ++ doc/src/sgml/libpq