Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 20:30, Tom Lane wrote: > Andres Freund writes: >> On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >>> TBH, I would just remove those test cases. Even if they were stable >>> across platforms, they don't directly prove anything at all

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 19:52, Andres Freund wrote: > On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >> Andres Freund writes: >> > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >> >> Am investigating the few buildfarm failures >> >> > The tests look very

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Tom Lane
Andres Freund writes: > On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >> TBH, I would just remove those test cases. Even if they were stable >> across platforms, they don't directly prove anything at all about >> whether the feature does what it's supposed to. > I think it

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 19:49, Tom Lane wrote: > Andres Freund writes: >> On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >>> Am investigating the few buildfarm failures > >> The tests look very sensitive to differences in tuple size due to >> different

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Andres Freund
On 2017-11-19 19:49:01 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: > >> Am investigating the few buildfarm failures > > > The tests look very sensitive to differences in tuple size due to > > different alignment

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Tom Lane
Andres Freund writes: > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >> Am investigating the few buildfarm failures > The tests look very sensitive to differences in tuple size due to > different alignment requirements. Dependant on what MAXALIGN (and some > others) is

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 17:52, Simon Riggs wrote: > Parameter toast_tuple_target controls TOAST for new rows > > Specifies the point at which we try to move long column values > into TOAST tables. > > No effect on existing rows. > > Discussion: >

pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
Parameter toast_tuple_target controls TOAST for new rows Specifies the point at which we try to move long column values into TOAST tables. No effect on existing rows. Discussion: https://postgr.es/m/CANP8+jKsVmw6CX6YP9z7zqkTzcKV1+Uzr3XjKcZW=2ya00o...@mail.gmail.com Author: Simon Riggs