Re: pgsql: Prevent redeclaration of typedef TocEntry.

2025-04-05 Thread Nathan Bossart
Sorry, I missed this one last night. On Sat, Apr 05, 2025 at 02:10:10AM -0400, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: >> ... AFAICS we could move both DefnDumperPtr and >> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct >> _tocEntry (the only place where th

Re: pgsql: Prevent redeclaration of typedef TocEntry.

2025-04-04 Thread Tom Lane
=?utf-8?Q?=C3=81lvaro?= Herrera writes: > ... AFAICS we could move both DefnDumperPtr and > DataDumperPtr typedefs to pg_backup_archiver.h, together with struct > _tocEntry (the only place where they are used), and we'd have less of a > mess here. Then we don't need struct TocEntry in pg_backup.h

Re: pgsql: Prevent redeclaration of typedef TocEntry.

2025-04-04 Thread Álvaro Herrera
On 2025-Apr-04, Nathan Bossart wrote: > Prevent redeclaration of typedef TocEntry. > > Commit 9c02e3a986 added a forward declaration for this typedef that > caused redeclarations, which is not valid in C99. To fix, add some > preprocessor guards to avoid a redefinition, as is done elsewhere > (e

pgsql: Prevent redeclaration of typedef TocEntry.

2025-04-04 Thread Nathan Bossart
Prevent redeclaration of typedef TocEntry. Commit 9c02e3a986 added a forward declaration for this typedef that caused redeclarations, which is not valid in C99. To fix, add some preprocessor guards to avoid a redefinition, as is done elsewhere (e.g., commit 382092a0cd). Per buildfarm. Branch --