On Thu, Sep 28, 2023 at 10:08 AM Tom Lane wrote:
> Amit Langote writes:
> > After these modifications, the ExecEnd*() routines for ValuesScan,
> > NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> > commit removes them.
>
> This seems like quite a bad idea. From a documentation
Amit Langote writes:
> After these modifications, the ExecEnd*() routines for ValuesScan,
> NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> commit removes them.
This seems like quite a bad idea. From a documentation standpoint
alone, it would be far better for these functions
Remove obsolete executor cleanup code
This commit removes unnecessary ExecExprFreeContext() calls in
ExecEnd* routines because the actual cleanup is managed by
FreeExecutorState(). With no callers remaining for
ExecExprFreeContext(), this commit also removes the function.
This commit also drops r