pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow

pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow

pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow

pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow

pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow

pgsql: Remove unnecessary failure cases in RemoveRoleFromObjectPolicy()

2021-06-25 Thread Tom Lane
Remove unnecessary failure cases in RemoveRoleFromObjectPolicy(). It's not really necessary for this function to open or lock the relation associated with the pg_policy entry it's modifying. The error checks it's making on the rel are if anything counterproductive (e.g., if we don't want to allow