Re: pgsql: Remove win32ver.rc from version_stamp.pl

2020-03-10 Thread Tom Lane
I wrote: > I'd suggest reverting the change in how PG_VERSION_NUM is computed > in configure.in --- that was certainly not necessary to the patch, > and evidently you're falling foul of some weird behavior around > nesting double-quotes and backquotes. Actually, you can just get rid of the nesting

Re: pgsql: Remove win32ver.rc from version_stamp.pl

2020-03-10 Thread Tom Lane
Peter Eisentraut writes: > This created some seemingly unrelated build farm failures. I suspect > this must have something to do with the new shell code in configure > +PG_MINORVERSION=`expr "$PACKAGE_VERSION" : '.*\.\([0-9][0-9]*\)'` > +test -n "$PG_MINORVERSION" || PG_MINORVERSION=0 > ending

Re: pgsql: Remove win32ver.rc from version_stamp.pl

2020-03-10 Thread Peter Eisentraut
On 2020-03-10 11:22, Peter Eisentraut wrote: What we need for this is having the major version number and the minor version number as separate integer symbols. Both configure and Solution.pm already have that logic, because they compute PG_VERSION_NUM. So we just keep all the logic there now.

pgsql: Remove win32ver.rc from version_stamp.pl

2020-03-10 Thread Peter Eisentraut
Remove win32ver.rc from version_stamp.pl This removes another relic from the old nmake-based Windows build. version_stamp.pl put version number information into win32ver.rc. But win32ver.rc already gets other version number information from the preprocessor at build time, so it would make more se