Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-11 Thread Michael Paquier
On Mon, Feb 11, 2019 at 10:59:20AM +0100, Peter Eisentraut wrote: > Committed that way. Thanks Peter for adjusting the message, I was just going to do it. There was a long weekend here and I had zero access to my laptop, explaining the delay in replying. -- Michael signature.asc Description: PGP

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-11 Thread Peter Eisentraut
On 09/02/2019 16:06, Peter Eisentraut wrote: > On 08/02/2019 11:00, Michael Paquier wrote: >> On Fri, Feb 08, 2019 at 10:41:59AM +0100, Peter Eisentraut wrote: >>> We usually don't use "namespace" in user-facing error messages. Can you >>> change it to say "temporary schema"? >> >> Or just switch

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-09 Thread Peter Eisentraut
On 08/02/2019 11:00, Michael Paquier wrote: > On Fri, Feb 08, 2019 at 10:41:59AM +0100, Peter Eisentraut wrote: >> We usually don't use "namespace" in user-facing error messages. Can you >> change it to say "temporary schema"? > > Or just switch to "temporary objects" like it's done on HEAD for t

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-08 Thread Michael Paquier
On Fri, Feb 08, 2019 at 10:41:59AM +0100, Peter Eisentraut wrote: > We usually don't use "namespace" in user-facing error messages. Can you > change it to say "temporary schema"? Or just switch to "temporary objects" like it's done on HEAD for the second message? Please note that I have kept the

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-02-08 Thread Peter Eisentraut
On 18/01/2019 01:22, Michael Paquier wrote: > Restrict the use of temporary namespace in two-phase transactions We usually don't use "namespace" in user-facing error messages. Can you change it to say "temporary schema"? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL De

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-01-17 Thread Tom Lane
Michael Paquier writes: > I have been monitoring the buildfarm and crake is complaining: > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=crake&br=HEAD > I am actually amazed to see the planner choose a parallel plan for > that, That's due to force_parallel_mode = regress, I imagine

Re: pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-01-17 Thread Michael Paquier
On Fri, Jan 18, 2019 at 12:22:52AM +, Michael Paquier wrote: > Restrict the use of temporary namespace in two-phase transactions > > Attempting to use a temporary table within a two-phase transaction is > forbidden for ages. However, there have been uncovered grounds for > a couple of other o

pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-01-17 Thread Michael Paquier
Restrict the use of temporary namespace in two-phase transactions Attempting to use a temporary table within a two-phase transaction is forbidden for ages. However, there have been uncovered grounds for a couple of other object types and commands which work on temporary objects with two-phase com

pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-01-17 Thread Michael Paquier
Restrict the use of temporary namespace in two-phase transactions Attempting to use a temporary table within a two-phase transaction is forbidden for ages. However, there have been uncovered grounds for a couple of other object types and commands which work on temporary objects with two-phase com

pgsql: Restrict the use of temporary namespace in two-phase transaction

2019-01-17 Thread Michael Paquier
Restrict the use of temporary namespace in two-phase transactions Attempting to use a temporary table within a two-phase transaction is forbidden for ages. However, there have been uncovered grounds for a couple of other object types and commands which work on temporary objects with two-phase com