Re: pgsql: Rework XLogReader callback system

2020-05-08 Thread Alvaro Herrera
Hello, On 2020-May-08, Alvaro Herrera wrote: > Rework XLogReader callback system I think this commit is causing buildfarm members bowerbird to crash, but it's not getting any backtrace. Is it perchance possible to enable whatever buildfarm feature it is that reports backtraces from crashes? Tha

pgsql: Rework XLogReader callback system

2020-05-08 Thread Alvaro Herrera
Rework XLogReader callback system Code review for 0dc8ead46363, prompted by a bug closed by 91c40548d5f7. XLogReader's system for opening and closing segments had gotten too complicated, with callbacks being passed at both the XLogReaderAllocate level (read_page) as well as at the WALRead level (