Re: pgsql: Rewrite some RI code to avoid using SPI

2022-04-07 Thread Tom Lane
Alvaro Herrera writes: > On 2022-Apr-07, Tom Lane wrote: >> (1) We've added enough instability to the tree this week already. > Several animals failed already in ways that look obviously connected to > this commit, so I can't disagree: Yeah, I saw that after complaining. Looks like all and only

Re: pgsql: Rewrite some RI code to avoid using SPI

2022-04-07 Thread Alvaro Herrera
On 2022-Apr-07, Tom Lane wrote: > Just for the record, I didn't approve of that patch, and I don't > think cramming it in a few hours before feature freeze is a good > way to proceed. > (1) We've added enough instability to the tree this week already. Several animals failed already in ways that

Re: pgsql: Rewrite some RI code to avoid using SPI

2022-04-07 Thread Tom Lane
Alvaro Herrera writes: > Rewrite some RI code to avoid using SPI Just for the record, I didn't approve of that patch, and I don't think cramming it in a few hours before feature freeze is a good way to proceed. (1) We've added enough instability to the tree this week already. (2) I'm still quit

pgsql: Rewrite some RI code to avoid using SPI

2022-04-07 Thread Alvaro Herrera
Rewrite some RI code to avoid using SPI Modify the subroutines called by RI trigger functions that want to check if a given referenced value exists in the referenced relation to simply scan the foreign key constraint's unique index, instead of using SPI to execute SELECT 1 FROM referenced_relati