Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 27 Mar 2022, at 00:19, Tom Lane wrote: > Not sure why I don't have it enabled on florican, will fix that. Thanks, much appreciated! -- Daniel Gustafsson https://vmware.com/

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Tom Lane
Daniel Gustafsson writes: > A semi-related comment, I wish more of the animals ran ssl-check and not just > compiled with OpenSSL, it would be nice to have the SSL test excercised more. FWIW, the following active animals seem to have that enabled: chipmunk crake drongo eelpout elver fairyw

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 26 Mar 2022, at 23:19, Andrew Dunstan wrote: > On 3/26/22 18:15, Tom Lane wrote: >> Looks like crake has a hard-wired list of INC directories for this step, >> that now needs to be extended to include src/test/ssl/t/. > Exactly. New run is currently executing. Thanks, I'm keeping an eye on

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Andrew Dunstan
On 3/26/22 18:15, Tom Lane wrote: > Daniel Gustafsson writes: >> crake complained in the Perl check due to not being able to locate the new >> backend specific module: >> Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK >> Mar 26 17:54:33 Can't locate SSL/Backend/OpenSSL.pm in @

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Tom Lane
Daniel Gustafsson writes: > crake complained in the Perl check due to not being able to locate the new > backend specific module: > Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK > Mar 26 17:54:33 Can't locate SSL/Backend/OpenSSL.pm in @INC (you may need to > install the SSL::

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 26 Mar 2022, at 22:06, Daniel Gustafsson > wrote: > > SSL TAP test backend library independence refactoring crake complained in the Perl check due to not being able to locate the new backend specific module: Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK Mar 26 17:54:33

pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
SSL TAP test backend library independence refactoring The SSL TAP tests were tightly coupled to the OpenSSL implementation, making it hard to add support for additional SSL/TLS backends. This refactoring makes the test avoid depending on specific implementations The SSLServer Perl module is rena