Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-19 Thread Alvaro Herrera
On 2022-Mar-19, Amit Langote wrote: > Actually, I also noticed that the v16 patch you posted in the "Re: a > misbehavior of partition row movement (?)" thread contained this same > fix. I like the wording in that patch, though I guess it's better to > commit the fix separately from the big patch

Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-18 Thread Amit Langote
On Sat, Mar 19, 2022 at 12:59 PM Amit Langote wrote: > On Thu, Mar 17, 2022 at 7:47 PM Alvaro Herrera > wrote: > > > > Split ExecUpdate and ExecDelete into reusable pieces > > > > Create subroutines ExecUpdatePrologue / ExecUpdateAct / > > ExecUpdateEpilogue, and similar for ExecDelete. > > > >

Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-18 Thread Amit Langote
Hi Alvaro, On Thu, Mar 17, 2022 at 7:47 PM Alvaro Herrera wrote: > > Split ExecUpdate and ExecDelete into reusable pieces > > Create subroutines ExecUpdatePrologue / ExecUpdateAct / > ExecUpdateEpilogue, and similar for ExecDelete. > > Introduce a new struct to be used internally in nodeModifyTab

pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-17 Thread Alvaro Herrera
Split ExecUpdate and ExecDelete into reusable pieces Create subroutines ExecUpdatePrologue / ExecUpdateAct / ExecUpdateEpilogue, and similar for ExecDelete. Introduce a new struct to be used internally in nodeModifyTable.c, dubbed ModifyTableContext, which contains all context information needed