Re: pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Andrew Dunstan
On 3/21/21 2:16 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Ugh.  Is there any reason we need to do those kills before we end the >> psql processes? If not I'm tempted just to move them - after the psql's >> are finished it should be safe. At any rate I'll go and test that. > IIUC, that'd co

Re: pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Tom Lane
Andrew Dunstan writes: > Ugh.  Is there any reason we need to do those kills before we end the > psql processes? If not I'm tempted just to move them - after the psql's > are finished it should be safe. At any rate I'll go and test that. IIUC, that'd completely destroy the point of the test, whic

Re: pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Andrew Dunstan
On 3/21/21 1:06 PM, Andrew Dunstan wrote: > On 3/21/21 12:38 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Unbreak recovery test on Windows >> Hmm, looks like this broke things on other machines. >> crake and sifaka (so far) are showing >> >> # Running: pg_ctl kill KILL 2237831 >> ok 3 - kil

Re: pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Andrew Dunstan
On 3/21/21 12:38 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Unbreak recovery test on Windows > Hmm, looks like this broke things on other machines. > crake and sifaka (so far) are showing > > # Running: pg_ctl kill KILL 2237831 > ok 3 - killed process with KILL > ack Broken pipe: write( 13,

Re: pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Tom Lane
Andrew Dunstan writes: > Unbreak recovery test on Windows Hmm, looks like this broke things on other machines. crake and sifaka (so far) are showing # Running: pg_ctl kill KILL 2237831 ok 3 - killed process with KILL ack Broken pipe: write( 13, '\\q ' ) at /usr/share/perl5/vendor_perl/IPC/Run/IO

pgsql: Unbreak recovery test on Windows

2021-03-21 Thread Andrew Dunstan
Unbreak recovery test on Windows On Windows we need to send explicit quit messages to psql or the TAP tests can hang. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/677271a3a125e294b33b891669f594a2c8cb36ce Modified Files -- src/test/recovery/t/022_cras