Re: pgsql: Unbreak the build.

2022-03-23 Thread Robert Haas
On Wed, Mar 23, 2022 at 11:55 AM Tom Lane wrote: > Andres Freund writes: > > And windows still fails tests after this commit: > > https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22 > > Yeah. drongo is reporting > > # Running: pg_basebackup --no-sync -cfast -D > C:\\prog\\bf\\root\\H

Re: pgsql: Unbreak the build.

2022-03-23 Thread Tom Lane
Andres Freund writes: > And windows still fails tests after this commit: > https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22 Yeah. drongo is reporting # Running: pg_basebackup --no-sync -cfast -D C:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\tmp_check\\tmp_test_v

Re: pgsql: Unbreak the build.

2022-03-23 Thread Andres Freund
Hi, On 2022-03-23 11:38:39 -0400, Robert Haas wrote: > On Wed, Mar 23, 2022 at 10:46 AM Andres Freund wrote: > > There's new warnings that sound reasonable introduced in the prior commit > > that didn't get removed in this one: > > > > https://cirrus-ci.com/task/5259487073271808?logs=mingw_cross

Re: pgsql: Unbreak the build.

2022-03-23 Thread Robert Haas
On Wed, Mar 23, 2022 at 10:46 AM Andres Freund wrote: > There's new warnings that sound reasonable introduced in the prior commit > that didn't get removed in this one: > > https://cirrus-ci.com/task/5259487073271808?logs=mingw_cross_warning#L392 That link takes me to a screen that shows no warn

Re: pgsql: Unbreak the build.

2022-03-23 Thread Andres Freund
Hi, On March 23, 2022 7:46:10 AM PDT, Andres Freund wrote: >Hi, > >On March 23, 2022 7:24:13 AM PDT, Robert Haas wrote: >>Unbreak the build. >> >>Commit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 broke the build for >>anyone not compiling with LZ4 and ZSTD enabled. Woops. > >There's new warnings

Re: pgsql: Unbreak the build.

2022-03-23 Thread Andres Freund
Hi, On March 23, 2022 7:24:13 AM PDT, Robert Haas wrote: >Unbreak the build. > >Commit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 broke the build for >anyone not compiling with LZ4 and ZSTD enabled. Woops. There's new warnings that sound reasonable introduced in the prior commit that didn't get

pgsql: Unbreak the build.

2022-03-23 Thread Robert Haas
Unbreak the build. Commit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 broke the build for anyone not compiling with LZ4 and ZSTD enabled. Woops. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/607e75e8f0f84544feb879b747da1d40fed71499 Modified Files -- src/