Re: pgsql: Use setenv() in preference to putenv().

2020-12-30 Thread Tom Lane
Alexander Korotkov writes: > On Wed, Dec 30, 2020 at 8:56 PM Tom Lane wrote: >> Use setenv() in preference to putenv(). > Recent buildfarm failure on crake seems to be related to this commit. Yeah, see https://www.postgresql.org/message-id/flat/2403475.1609360967%40sss.pgh.pa.us

Re: pgsql: Use setenv() in preference to putenv().

2020-12-30 Thread Alexander Korotkov
Hi! On Wed, Dec 30, 2020 at 8:56 PM Tom Lane wrote: > Use setenv() in preference to putenv(). Recent buildfarm failure on crake seems to be related to this commit. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2020-12-31%2001%3A34%3A28 pg_restore: while PROCESSING TOC: pg_res

pgsql: Use setenv() in preference to putenv().

2020-12-30 Thread Tom Lane
Use setenv() in preference to putenv(). Since at least 2001 we've used putenv() and avoided setenv(), on the grounds that the latter was unportable and not in POSIX. However, POSIX added it that same year, and by now the situation has reversed: setenv() is probably more portable than putenv(), si