Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-12-11 Thread Daniel Gustafsson
> On 8 Dec 2023, at 14:38, Daniel Gustafsson wrote: > I will apply that to v12 shortly after a little more testing. Done, and canebrake/urutu has since turned green. -- Daniel Gustafsson

Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-12-08 Thread Daniel Gustafsson
> On 20 Nov 2023, at 22:53, Daniel Gustafsson wrote: > >> On 19 Nov 2023, at 21:08, Daniel Gustafsson wrote: > >> I'll have a look with fresh eyes in the morning, and hopefully it will be >> fixable. If it get's messy it's quite possible that skipping v12 is the best >> option. > > As an upda

Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-20 Thread Daniel Gustafsson
> On 19 Nov 2023, at 21:08, Daniel Gustafsson wrote: > I'll have a look with fresh eyes in the morning, and hopefully it will be > fixable. If it get's messy it's quite possible that skipping v12 is the best > option. As an update, discussing with Andres off-list I have a potential patch for th

Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-19 Thread Daniel Gustafsson
> On 19 Nov 2023, at 17:05, Tom Lane wrote: > > Daniel Gustafsson writes: >> llvmjit: Use explicit LLVMContextRef for inlining > > It looks like the v12 back-port of this wasn't quite right: > canebrake and urutu have both been showing assertion failures > down inside LLVMContextDispose since i

Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-19 Thread Tom Lane
Daniel Gustafsson writes: > llvmjit: Use explicit LLVMContextRef for inlining It looks like the v12 back-port of this wasn't quite right: canebrake and urutu have both been showing assertion failures down inside LLVMContextDispose since it went in. They aren't complaining about v13 and later, th

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-17 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-17 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-17 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-17 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-17 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri

pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-09-27 Thread Daniel Gustafsson
llvmjit: Use explicit LLVMContextRef for inlining When performing inlining LLVM unfortunately "leaks" types (the types survive and are usable, but a new round of inlining will recreate new structurally equivalent types). This accumulation will over time amount to a memory leak which for some queri