Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
On Thu, Jan 27, 2022 at 2:22 PM Justin Pryzby wrote: > On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote: > > On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > > > If I'm not wrong, this is causing failures on cfbot. > > > https://cirrus-ci.com/task/6312181619752960?logs=build#L20

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote: > On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > > If I'm not wrong, this is causing failures on cfbot. > > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > > > [17:24:48.348] c:\cirrus\src\backend\replication\ba

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > If I'm not wrong, this is causing failures on cfbot. > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): > warning C4715: 'bbsink_gzip_new': not all contr

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 04:15:45PM +, Robert Haas wrote: > pg_basebackup: Fix a couple of recently-introduced bugs. > > The server expects the compression level to be between 1 and 9, but > Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value > to the server. If I'm not wrong, t

pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
pg_basebackup: Fix a couple of recently-introduced bugs. The server expects the compression level to be between 1 and 9, but Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value to the server. Because pg_basebackup's -R option is implemented on the client side, it can't be used in c