pg_waldump: Fix invalid option handling Previously, running pg_waldump with an invalid option (pg_waldump --foo) would print the help output and exit successfully. This was because it tried to process the option letter '?' as a normal option, but that letter is used by getopt() to report an invalid option.
To fix, process help and version options separately, like we do everywhere else. Also add a basic test suite for pg_waldump and run the basic option handling tests, which would have caught this. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f65eced25118aab29804debc4e0b9a67f4d043ad Modified Files -------------- src/bin/pg_waldump/.gitignore | 3 +++ src/bin/pg_waldump/Makefile | 7 +++++++ src/bin/pg_waldump/pg_waldump.c | 25 ++++++++++++++++--------- src/bin/pg_waldump/t/001_basic.pl | 8 ++++++++ 4 files changed, 34 insertions(+), 9 deletions(-)
