Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Tom Lane
Andres Freund writes: > The log excerpt appears to be from bowerbird [1], and predates that commit. I > didn't see any windows buildfarm run that completed since the above commit. bowerbird just came through with a green run. regards, tom lane

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Andres Freund
Hi, On 2021-11-06 19:07:29 -0700, Andres Freund wrote: > On 2021-11-07 10:38:07 +0900, Michael Paquier wrote: > > On Sat, Nov 06, 2021 at 03:34:20PM -0700, Andres Freund wrote: > > > It was sufficient. The tests are still running, but the pgcrypto test just > > > passed (see contribcheck_test): >

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Andres Freund
Hi, On 2021-11-07 10:38:07 +0900, Michael Paquier wrote: > On Sat, Nov 06, 2021 at 03:34:20PM -0700, Andres Freund wrote: > > It was sufficient. The tests are still running, but the pgcrypto test just > > passed (see contribcheck_test): > > https://cirrus-ci.com/task/6128369478664192 > > vs previo

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Michael Paquier
On Sat, Nov 06, 2021 at 03:34:20PM -0700, Andres Freund wrote: > It was sufficient. The tests are still running, but the pgcrypto test just > passed (see contribcheck_test): > https://cirrus-ci.com/task/6128369478664192 > vs previous run before rebasing: > https://cirrus-ci.com/task/585675017682944

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Andres Freund
Hi, On 2021-11-06 18:07:09 -0400, Tom Lane wrote: > Andres Freund writes: > > This appears to have broken msvc pgcrypto being tested with msvc. I think > > that's because pgcrypto is still listed in the "base" @contrib_excludes and > > thus just isn't getting built anymore, now that the special-c

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Tom Lane
Andres Freund writes: > This appears to have broken msvc pgcrypto being tested with msvc. I think > that's because pgcrypto is still listed in the "base" @contrib_excludes and > thus just isn't getting built anymore, now that the special-case build rule is > gone? I came to the same conclusion an

Re: pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-06 Thread Andres Freund
Hi, On 2021-11-05 13:09:55 +, Peter Eisentraut wrote: > pgcrypto: Remove non-OpenSSL support > > pgcrypto had internal implementations of some encryption algorithms, > as an alternative to calling out to OpenSSL. These were rarely used, > since most production installations are built with Op

pgsql: pgcrypto: Remove non-OpenSSL support

2021-11-05 Thread Peter Eisentraut
pgcrypto: Remove non-OpenSSL support pgcrypto had internal implementations of some encryption algorithms, as an alternative to calling out to OpenSSL. These were rarely used, since most production installations are built with OpenSSL. Moreover, maintaining parallel code paths makes the code more