Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-08-01 Thread Etsuro Fujita
On Sun, Aug 1, 2021 at 4:59 PM Etsuro Fujita wrote: > But I plan on applying the patch tomorrow. Done, in hopes of making the buildfarm back to green. Best regards, Etsuro Fujita

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-08-01 Thread Etsuro Fujita
On Sun, Aug 1, 2021 at 1:41 AM Tom Lane wrote: > I tried this patch on a spare machine that seems prone to showing > the failure: on HEAD, postgres_fdw's installcheck failed 3 times > in 4 attempts. With the patch, it's gotten through 23 consecutive > tries without a failure. So this is at least

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-31 Thread Tom Lane
Etsuro Fujita writes: > I couldn’t reproduce this in my environment, but I noticed this, which > didn’t happen in my environment: the case of delivering notifications > to both of the parent async-capable nodes in ExecAppendAsyncEventWait > when processing the added test case query. In that case,

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-31 Thread Etsuro Fujita
On Fri, Jul 30, 2021 at 10:00 PM Etsuro Fujita wrote: > On Fri, Jul 30, 2021 at 9:45 PM Michael Paquier wrote: > > On Fri, Jul 30, 2021 at 08:08:07AM +, Etsuro Fujita wrote: > > > postgres_fdw: Fix handling of pending asynchronous requests. > > > > You have angered many members of the buildfa

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-30 Thread Etsuro Fujita
Hi Michael-san, On Fri, Jul 30, 2021 at 9:45 PM Michael Paquier wrote: > On Fri, Jul 30, 2021 at 08:08:07AM +, Etsuro Fujita wrote: > > postgres_fdw: Fix handling of pending asynchronous requests. > > You have angered many members of the buildfarm here, like: > https://buildfarm.postgresql.or

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-30 Thread Michael Paquier
Hi Fujita-san, On Fri, Jul 30, 2021 at 08:08:07AM +, Etsuro Fujita wrote: > postgres_fdw: Fix handling of pending asynchronous requests. You have angered many members of the buildfarm here, like: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mule&dt=2021-07-30%2011%3A30%3A04 This i

pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-30 Thread Etsuro Fujita
postgres_fdw: Fix handling of pending asynchronous requests. A pending asynchronous request is handled by process_pending_request(), which previously not only processed an in-progress remote query but performed ExecForeignScan() to produce a tuple to return to the local server asynchronously from

pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-07-30 Thread Etsuro Fujita
postgres_fdw: Fix handling of pending asynchronous requests. A pending asynchronous request is handled by process_pending_request(), which previously not only processed an in-progress remote query but performed ExecForeignScan() to produce a tuple to return to the local server asynchronously from