Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Amit Kapila
On Sat, Nov 11, 2017 at 10:58 PM, Andreas Seltenreich wrote: > Hi, > > sqlsmith doesn't like commit 4b0d28de06: > > , > | regression=> select * from pg_control_checkpoint(); > | server closed the connection unexpectedly > | TRAP: FailedAssertion("!((atti->attalign) == 's')", File: "heaptuple.c

pgsql: Pass eflags down to parallel workers.

2017-11-20 Thread Robert Haas
Pass eflags down to parallel workers. Currently, there are no known consequences of this oversight, so no back-patch. Several of the EXEC_FLAG_* constants aren't usable in parallel mode anyway, and potential problems related to the presence or absence of OIDs (see EXEC_FLAG_WITH_OIDS, EXEC_FLAG_W

pgsql: Tweak use of ExecContextForcesOids by Gather (Merge).

2017-11-20 Thread Robert Haas
Tweak use of ExecContextForcesOids by Gather (Merge). Specifically, pass the outer plan's PlanState instead of our own PlanState. At present, ExecContextForcesOids doesn't actually care which PlanState we pass; it just looks through to the underlying EState to find the result relation or top-leve

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

2017-11-20 Thread Andres Freund
Hi, On 2017-11-13 19:03:41 -0800, Andres Freund wrote: > Hi, > > On 2017-11-03 07:53:30 -0700, Andres Freund wrote: > > Here's that patch. I've stared at this some, and Robert did too. Robert > > mentioned that the commit message might need some polish and I'm not > > 100% sure about the error m

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Simon Riggs
On 20 November 2017 at 08:38, Amit Kapila wrote: > On Sat, Nov 11, 2017 at 10:58 PM, Andreas Seltenreich > wrote: >> Hi, >> >> sqlsmith doesn't like commit 4b0d28de06: >> >> , >> | regression=> select * from pg_control_checkpoint(); >> | server closed the connection unexpectedly >> | TRAP: Fa

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Andres Freund
On 2017-11-20 15:50:40 -0500, Simon Riggs wrote: > On 20 November 2017 at 08:38, Amit Kapila wrote: > > Your patch looks correct to me. I can reproduce the problem and > > verified that patch fixes the problem. It is better to track this in > > CF if not already tracked. > > What email and patc

pgsql: Fix pg_control_checkpoint from commit 4b0d28de06

2017-11-20 Thread Simon Riggs
Fix pg_control_checkpoint from commit 4b0d28de06 Author: Simon Riggs Reported-By: Andreas Seltenreich Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2ede45c3a49e484edfa143850d55eb32dba296de Modified Files -- src/backend/utils/misc/pg_controldata.c |

Re: pgsql: Fix pg_control_checkpoint from commit 4b0d28de06

2017-11-20 Thread Andres Freund
On 2017-11-20 21:04:08 +, Simon Riggs wrote: > Fix pg_control_checkpoint from commit 4b0d28de06 > > Author: Simon Riggs > Reported-By: Andreas Seltenreich Wasn't Andreas both author and reporter here?

Re: pgsql: Fix pg_control_checkpoint from commit 4b0d28de06

2017-11-20 Thread Simon Riggs
On 20 November 2017 at 16:05, Andres Freund wrote: > On 2017-11-20 21:04:08 +, Simon Riggs wrote: >> Fix pg_control_checkpoint from commit 4b0d28de06 >> >> Author: Simon Riggs >> Reported-By: Andreas Seltenreich > > Wasn't Andreas both author and reporter here? In fact, no, since I couldn't

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Simon Riggs
On 20 November 2017 at 15:55, Andres Freund wrote: > On 2017-11-20 15:50:40 -0500, Simon Riggs wrote: >> On 20 November 2017 at 08:38, Amit Kapila wrote: >> > Your patch looks correct to me. I can reproduce the problem and >> > verified that patch fixes the problem. It is better to track this i

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresq

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/p

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresq

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- REL9_4_STABLE Details --- https://git.postgresq

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- REL9_3_STABLE Details --- https://git.postgresq

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD

2017-11-20 Thread Tom Lane
Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD. David Carlier (from a patch being carried by OpenBSD packagers) Discussion: https://postgr.es/m/ca+xhmqzwfsgvu7menfhcecc8ydp98tigxzzpd0aadwagwav...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresq

pgsql: Add support for Motorola 88K to s_lock.h.

2017-11-20 Thread Tom Lane
Add support for Motorola 88K to s_lock.h. Apparently there are still people out there who care about this old architecture. They probably care about dusty versions of Postgres too, so back-patch to all supported branches. David Carlier (from a patch being carried by OpenBSD packagers) Discussio

pgsql: Support index-only scans in contrib/cube and contrib/seg GiST in

2017-11-20 Thread Tom Lane
Support index-only scans in contrib/cube and contrib/seg GiST indexes. To do this, we only have to remove the compress and decompress support functions, which have never done anything more than detoasting. In the wake of commit d3a4f89d8, this results in automatically enabling index-only scans, si