pgsql: Fix Latin spelling

2018-01-11 Thread Peter Eisentraut 
Fix Latin spelling

"c.f." should be "cf.".

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9e945f862633882cae3183d465f321bd8dd591f9

Modified Files
--
src/backend/catalog/catalog.c   | 2 +-
src/backend/optimizer/util/clauses.c| 2 +-
src/backend/replication/logical/origin.c| 2 +-
src/backend/replication/logical/reorderbuffer.c | 4 ++--
src/backend/replication/logical/snapbuild.c | 2 +-
src/backend/storage/ipc/procarray.c | 2 +-
src/backend/utils/cache/relcache.c  | 2 +-
src/bin/psql/describe.c | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)

pgsql: Fix behavior of ~> (cube, int) operator

2018-01-11 Thread Teodor Sigaev 
Fix behavior of ~> (cube, int) operator

~> (cube, int) operator was especially designed for knn-gist search.
However, it appears that knn-gist search can't work correctly with current
behavior of this operator when dataset contains cubes of variable
dimensionality. In this case, the same value of second operator argument
can point to different dimension depending on dimensionality of particular cube.
Such behavior is incompatible with gist indexing of cubes, and knn-gist doesn't
work correctly for it.

This patch changes behavior of ~> (cube, int) operator by introducing dimension
numbering where value of second argument unambiguously identifies number of
dimension. With new behavior, this operator can be correctly supported by
knn-gist. Relevant changes to cube operator class are also included.

Backpatch to v9.6 where operator was introduced.

Since behavior of ~> (cube, int) operator is changed, depending entities
must be refreshed after upgrade. Such as, expression indexes using this
operator must be reindexed, materialized views must be rebuilt, stored
procedures and client code must be revised to correctly use new behavior.
That should be mentioned in release notes.

Noticed by: Tomas Vondra
Author: Alexander Korotkov
Reviewed by: Tomas Vondra, Andrey Borodin
Discussion: 
https://www.postgresql.org/message-id/flat/a9657f6a-b497-36ff-e56-482a2c7e3...@2ndquadrant.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bda5281fdc5e41b6f54ff8f47df2ca37df00a19e

Modified Files
--
contrib/cube/cube.c  | 118 ---
contrib/cube/expected/cube.out   | 317 ---
contrib/cube/expected/cube_1.out | 317 ---
contrib/cube/expected/cube_2.out | 317 ---
contrib/cube/expected/cube_3.out | 317 ---
contrib/cube/sql/cube.sql|  35 +++--
doc/src/sgml/cube.sgml   |   9 +-
7 files changed, 902 insertions(+), 528 deletions(-)

pgsql: Add QueryEnvironment to ExplainOneQuery_hook's parameter list.

2018-01-11 Thread Tom Lane 
Add QueryEnvironment to ExplainOneQuery_hook's parameter list.

This should have been done in commit 18ce3a4ab, which added that parameter
to ExplainOneQuery, but it was overlooked.  This makes it impossible for
a user of the hook to pass the queryEnv down to ExplainOnePlan.

It's too late to change this API in v10, I suppose, but fortunately
passing NULL to ExplainOnePlan will work in nearly all interesting
cases in v10.  That might not be true forever, so we'd better fix it.

Tatsuro Yamada, reviewed by Thomas Munro

Discussion: 
https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee...@lab.ntt.co.jp

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4d41b2e0926548e338d20875729a55d41289f867

Modified Files
--
src/backend/commands/explain.c | 2 +-
src/include/commands/explain.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)

pgsql: Cosmetic fix in postgres_fdw.c.

2018-01-11 Thread Tom Lane 
Cosmetic fix in postgres_fdw.c.

Make the forward declaration of estimate_path_cost_size match its
actual definition.

Tatsuro Yamada

Discussion: 
https://postgr.es/m/96f2f554-1eeb-fe6f-e0db-650771886...@lab.ntt.co.jp

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9ff4f758ee430dbce0be13ab5da315be52cb6f55

Modified Files
--
contrib/postgres_fdw/postgres_fdw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: doc: add JSON acronym

2018-01-11 Thread Bruce Momjian 
doc:  add JSON acronym

Reported-by: torsten.gr...@gmail.com

Discussion: 
https://postgr.es/m/20171024201849.1488.71...@wrigleys.postgresql.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ca454b9bd34c75995eda4d07c9858f7c22890c2b

Modified Files
--
doc/src/sgml/acronyms.sgml | 10 ++
1 file changed, 10 insertions(+)

pgsql: Refactor subscription tests to use PostgresNode's wait_for_catch

2018-01-11 Thread Peter Eisentraut 
Refactor subscription tests to use PostgresNode's wait_for_catchup

This was nearly the same code.  Extend wait_for_catchup to allow waiting
for pg_current_wal_lsn() and use that in the subscription tests.  Also
change one use in the pg_rewind tests to use this.

Also remove some broken code in wait_for_catchup and
wait_for_slot_catchup.  The error message in case the waiting failed
wanted to show the current LSN, but the way it was written never
worked.  So since nobody ever cared, just remove it.

Reviewed-by: Michael Paquier 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/bbd3363e128daec0e70952c1bb2f12ab1f6f1292

Modified Files
--
src/bin/pg_rewind/RewindTest.pm|  5 +
src/test/perl/PostgresNode.pm  | 22 +++---
src/test/subscription/t/001_rep_changes.pl | 19 +--
src/test/subscription/t/002_types.pl   | 15 ---
src/test/subscription/t/003_constraints.pl | 15 ---
src/test/subscription/t/004_sync.pl| 14 +++---
src/test/subscription/t/005_encoding.pl| 13 ++---
src/test/subscription/t/006_rewrite.pl | 17 -
src/test/subscription/t/007_ddl.pl | 11 +--
src/test/subscription/t/008_diff_schema.pl | 15 +++
10 files changed, 42 insertions(+), 104 deletions(-)

pgsql: C comment: fix "the the" mentions in C comments

2018-01-11 Thread Bruce Momjian 
C comment:  fix "the the" mentions in C comments

Reported-by: Christoph Dreis

Discussion: https://postgr.es/m/007e01d3519e$2734ca10$759e5e30$@freenet.de

Author: Christoph Dreis

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/bdb70c12b3a2e69eec6e51411df60d9f43ecc841

Modified Files
--
src/backend/optimizer/prep/prepunion.c | 2 +-
src/test/regress/expected/triggers.out | 2 +-
src/test/regress/sql/triggers.sql  | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)