pgsql: Fix typo

2018-02-20 Thread Magnus Hagander
Fix typo Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a44a26b65d3d36867267624b76d3dea3dc4f6f6 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Adjust ALTER TABLE docs on partitioned constraints

2018-02-20 Thread Alvaro Herrera
Adjust ALTER TABLE docs on partitioned constraints Move the "additional restrictions" comment to ALTER TABLE ADD CONSTRAINT instead of ADD CONSTRAINT USING INDEX; and in the latter instead indicate that partitioned tables are unsupported Noted by David G. Johnston Discussion: https://postgr.es/m

pgsql: Fix pg_dump's logic for eliding sequence limits that match the d

2018-02-20 Thread Tom Lane
Fix pg_dump's logic for eliding sequence limits that match the defaults. The previous coding here applied atoi() to strings that could represent values too large to fit in an int. If the overflowed value happened to match one of the cases it was looking for, it would drop that limit value from th

pgsql: Fix pg_dump's logic for eliding sequence limits that match the d

2018-02-20 Thread Tom Lane
Fix pg_dump's logic for eliding sequence limits that match the defaults. The previous coding here applied atoi() to strings that could represent values too large to fit in an int. If the overflowed value happened to match one of the cases it was looking for, it would drop that limit value from th

pgsql: Error message improvement

2018-02-20 Thread Peter Eisentraut
Error message improvement Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c2ff42c6c1631c6c67d09fc8574186a984566a0d Modified Files -- src/backend/commands/tablecmds.c | 2 +- src/test/regress/expected/truncate.out | 4 ++-- 2 files changed, 3 insertio

pgsql: Use platform independent type for TupleTableSlot->tts_off.

2018-02-20 Thread Andres Freund
Use platform independent type for TupleTableSlot->tts_off. Previously tts_off was, for unknown reasons, of type long. For one that's unnecessary as tuples are restricted in length, for another long would be a bad choice of type even if that weren't the case, as it's not reliably wider than an int.

pgsql: Blindly attempt to adapt sepgsql regression tests.

2018-02-20 Thread Andres Freund
Blindly attempt to adapt sepgsql regression tests. Commit bf6c614a2f2c58312b3be34a47e7fb7362e07bcb broke the sepgsql test due to a new invocation of the function access hook during grouping equal initialization. The new behaviour seems at least as correct as the old one, so try adapt the tests. A

Re: pgsql: Do execGrouping.c via expression eval machinery, take two.

2018-02-20 Thread Andres Freund
Hi, On 2018-02-16 16:03:37 -0800, Andres Freund wrote: > This triggered a failure on rhinoceros, in the sepgsql test: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2018-02-16%2023%3A45%3A02 > > The relevant diff is: > + LOG: SELinux: allowed { execute } > scontext=unco

Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes.

2018-02-20 Thread Andres Freund
On 2018-02-06 19:25:04 +, Robert Haas wrote: > Avoid valgrind complaint about write() of uninitalized bytes. > > LogicalTapeFreeze() may write out its first block when it is dirty but > not full, and then immediately read the first block back in from its > BufFile as a BLCKSZ-width block. Thi