pgsql: Make capitalization of term "OpenSSL" more consistent

2018-06-28 Thread Michael Paquier
Make capitalization of term "OpenSSL" more consistent This includes code comments and documentation. No backpatch as this is cosmetic even if there are documentation changes which are user-facing. Author: Daniel Gustafsson Discussion:

Re: Tips on committing

2018-06-28 Thread Peter Geoghegan
On Thu, Jun 28, 2018 at 8:21 AM, Bruce Momjian wrote: > Good point. I have never used it but I can see its value. I have added > it to my template. FWIW, I developed a document on committing for my own reference, with some help from Andres. A lot of it is about commit message style, the use of

pgsql: Tag refs/tags/REL_11_BETA2 was created

2018-06-28 Thread pgsql
Tag refs/tags/REL_11_BETA2 was created.

Re: Tips on committing

2018-06-28 Thread Alvaro Herrera
On 2018-Jun-28, Peter Geoghegan wrote: > On Thu, Jun 28, 2018 at 8:21 AM, Bruce Momjian wrote: > > Good point. I have never used it but I can see its value. I have added > > it to my template. > > FWIW, I developed a document on committing for my own reference, with > some help from Andres.

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-28 Thread Tom Lane
Alvaro Herrera writes: > Fix "base" snapshot handling in logical decoding According to buildfarm member friarbird, and as confirmed here, the contrib/test_decoding/specs/oldest_xmin.spec test added by this commit fails under CLOBBER_CACHE_ALWAYS. friarbird's error output doesn't seem to be

pgsql: doc: backpatch mention use of cross platform logical replication

2018-06-28 Thread Bruce Momjian
doc: backpatch mention use of cross platform logical replication Backpatch 21c1f0c607f0344ae8f71ecaae1fe6f58cf7ff9a to PG 10 docs. Reported-by: Haribabu Kommi Discussion: https://postgr.es/m/CAJrrPGfdknoqZcMipPy8XnH3hO3uRic6JTD=jv35oj1dwql...@mail.gmail.com Backpatch-through: only 10 Branch

Tips on committing

2018-06-28 Thread Bruce Momjian
With seven new committers, I thought it would be good for me to give some tips I use in committing. I use a standard template that is this: 1 |--- gitweb/email subject limit -|-| 2 Reported-by: 3 Bug: 4 Discussion: 5 Author: 6

Re: Tips on committing

2018-06-28 Thread Bruce Momjian
On Thu, Jun 28, 2018 at 11:14:38AM -0400, Alvaro Herrera wrote: > I'm not sure pgsql-committers was the right audience. Cross-posting to > pg-hackers. > > On 2018-Jun-28, Bruce Momjian wrote: > > > 2 Reported-by: > > 5 Author: > > 6 Reviewed-by: > > 7 Tested-by: > >

Re: Tips on committing

2018-06-28 Thread Peter Geoghegan
On Thu, Jun 28, 2018 at 9:52 AM, Alvaro Herrera wrote: >> FWIW, I developed a document on committing for my own reference, with >> some help from Andres. > > Sounds very useful. > > How about turning it into a wiki page, for everybody's benefit? I'll try to do that, but I'd still recommend

Re: pgsql: Convert debug message from ereport to elog

2018-06-28 Thread Peter Eisentraut
On 6/15/18 06:53, Tatsuo Ishii wrote: > Therefore, elog should be used only for internal errors and low-level > debug logging. Also for these purposes ereport should not be used. ereport() has the advantage that if the debug level excludes the message, then the errmsg() call won't even be run and

Re: Tips on committing

2018-06-28 Thread Alvaro Herrera
I'm not sure pgsql-committers was the right audience. Cross-posting to pg-hackers. On 2018-Jun-28, Bruce Momjian wrote: > 2 Reported-by: > 5 Author: > 6 Reviewed-by: > 7 Tested-by: Should these include email addresses? I've also used "Diagnosed-by" to credit a person

Re: Tips on committing

2018-06-28 Thread Robert Haas
On Thu, Jun 28, 2018 at 11:20 AM, Andres Freund wrote: >> Apparently, there's a recent trend to credit patch authors using >> "Co-authored-by". Should we use that too? >> https://stackoverflow.com/a/41847267/ > > I just put multiple people into Authors, with order roughly implying the > amount

Re: Tips on committing

2018-06-28 Thread Andres Freund
On 2018-06-28 11:14:38 -0400, Alvaro Herrera wrote: > I'm not sure pgsql-committers was the right audience. Cross-posting to > pg-hackers. > > On 2018-Jun-28, Bruce Momjian wrote: > > > 2 Reported-by: > > 5 Author: > > 6 Reviewed-by: > > 7 Tested-by: > > Should these