pgsql: Fix two oversights from 9ebe0572 which refactored cluster_rel

Fix two oversights from 9ebe0572 which refactored cluster_rel The recheck option became a no-op as ClusterOption failed to set proper values for each element. There was a second code path where local options got overwritten. Both issues have been spotted by Coverity. Branch -- master Detai

pgsql: Make error message of pageinspect more consistent for raw page i

Make error message of pageinspect more consistent for raw page inputs There is a copy-paste error from bt_page_items() which got into bt_page_items_bytea(). A second message in get_raw_page_internal() was inconsistent with all the other sub-modules. Author: Ashutosh Sharma Discussion: https://p

Re: pgsql: Refactor geometric functions and operators

On Sun, Jul 29, 2018 at 12:43:29AM +, Tomas Vondra wrote: > Refactor geometric functions and operators > > The primary goal of this patch is to eliminate duplicate code and share > code between different geometric data types more often, to prepare the > ground for additional patches. Until no

Re: pgsql: Refactor geometric functions and operators

On 07/29/2018 04:59 PM, Michael Paquier wrote: > On Sun, Jul 29, 2018 at 12:43:29AM +, Tomas Vondra wrote: >> Refactor geometric functions and operators >> >> The primary goal of this patch is to eliminate duplicate code and share >> code between different geometric data types more often, to

Would like to help with documentation for Postgres 11

I would like to offer some help writing and improving the English documentation for some of the new features and changes in Postgres 11. If I can get an email of where such help would be appreciated, so I can choose a feature I am familiar with, I would be glad to help. Thanks, Michael Goldshteyn

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL9_6_STABLE Details --- https://git.postgresql.org

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL9_5_STABLE Details --- https://git.postgresql.org

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL9_4_STABLE Details --- https://git.postgresql.org

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- master Details --- https://git.postgresql.org/pg/com

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL_11_STABLE Details --- https://git.postgresql.org

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL9_3_STABLE Details --- https://git.postgresql.org

pgsql: Fix earthdistance test suite function name typo.

Fix earthdistance test suite function name typo. Affected test queries have been testing the wrong thing since their introduction in commit 4c1383efd132e4f532213c8a8cc63a455f55e344. Back-patch to 9.3 (all supported versions). Branch -- REL_10_STABLE Details --- https://git.postgresql.org

pgsql: Restore handling of -0 in the C field of lines in line_construct

Restore handling of -0 in the C field of lines in line_construct(). Commit a7dc63d904 inadvertedly removed this bit originally introduced by 43fe90f66a, causing regression test failures on some platforms, due to producing {1,-1,-0} instead of {1,-1,0}. Branch -- master Details --- https:

Re: Tips on committing

On Wed, Jul 11, 2018 at 4:35 PM, Peter Geoghegan wrote: > You've convinced me that we should definitely have such a list. I've > put it on my TODO list. I started this Wiki page: https://wiki.postgresql.org/wiki/Committing_checklist I've tried to avoid being too prescriptive. This is a work in

pgsql: Mark variable used only in assertion with PG_USED_FOR_ASSERTS_ON

Mark variable used only in assertion with PG_USED_FOR_ASSERTS_ONLY Perpendicular lines always intersect, so the line_interpt_line() return value in line_closept_point() was used only in an assertion, triggering compiler warnings in non-assert builds. Branch -- master Details --- https://