pgsql: Add some not null constraints to catalogs

2018-08-27 Thread Peter Eisentraut
Add some not null constraints to catalogs Use BKI_FORCE_NOT_NULL on some catalog field declarations that are never null (according to the source code that accesses them). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9b39b799db781642dd0c1424c28e827d19663e20 Modif

pgsql: Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY i

2018-08-27 Thread Tom Lane
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items. The archive should show a dependency on the item's table, but it failed to include one. This could cause failures in parallel restore due to emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring the table's data.

pgsql: Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY i

2018-08-27 Thread Tom Lane
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items. The archive should show a dependency on the item's table, but it failed to include one. This could cause failures in parallel restore due to emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring the table's data.

pgsql: Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY i

2018-08-27 Thread Tom Lane
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items. The archive should show a dependency on the item's table, but it failed to include one. This could cause failures in parallel restore due to emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring the table's data.

pgsql: Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY i

2018-08-27 Thread Tom Lane
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items. The archive should show a dependency on the item's table, but it failed to include one. This could cause failures in parallel restore due to emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring the table's data.

pgsql: Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY i

2018-08-27 Thread Tom Lane
Fix missing dependency for pg_dump's ENABLE ROW LEVEL SECURITY items. The archive should show a dependency on the item's table, but it failed to include one. This could cause failures in parallel restore due to emitting ALTER TABLE ... ENABLE ROW LEVEL SECURITY before restoring the table's data.

pgsql: Fix snapshot leak warning for some procedures

2018-08-27 Thread Peter Eisentraut
Fix snapshot leak warning for some procedures The problem arises with the combination of CALL with output parameters and doing a COMMIT inside the procedure. When a CALL has output parameters, the portal uses the strategy PORTAL_UTIL_SELECT instead of PORTAL_MULTI_QUERY. Using PORTAL_UTIL_SELECT

pgsql: Fix snapshot leak warning for some procedures

2018-08-27 Thread Peter Eisentraut
Fix snapshot leak warning for some procedures The problem arises with the combination of CALL with output parameters and doing a COMMIT inside the procedure. When a CALL has output parameters, the portal uses the strategy PORTAL_UTIL_SELECT instead of PORTAL_MULTI_QUERY. Using PORTAL_UTIL_SELECT

pgsql: Code review for simplehash.h.

2018-08-27 Thread Thomas Munro
Code review for simplehash.h. Fix reference to non-existent file in comment. Add SH_ prefix to the EMPTY and IN_USE tokens, to reduce likelihood of collisions with unrelated macros. Add include guards around the function definitions that are not "parameterized", so the header can be used again i