pgsql: Doc: make cross-reference to format() function more specific.

2018-12-07 Thread Tom Lane
Doc: make cross-reference to format() function more specific. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1w7Tn2M9BhK+rt8Shtz1AkU+ty7By8gj5C==z65=u4...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4c6d6acec5f228604d99162dfbc3b3c028dcf

pgsql: Doc: make cross-reference to format() function more specific.

2018-12-07 Thread Tom Lane
Doc: make cross-reference to format() function more specific. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1w7Tn2M9BhK+rt8Shtz1AkU+ty7By8gj5C==z65=u4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/62d8052ccd3fb8e26be1392a93167f83d937 Mo

pgsql: Clean up sloppy coding in publicationcmds.c's OpenTableList().

2018-12-07 Thread Tom Lane
Clean up sloppy coding in publicationcmds.c's OpenTableList(). Remove dead code (which would be incorrect if it weren't dead), per report from Pan Bian. Add a CHECK_FOR_INTERRUPTS in the inner loop over child relations, because there's little point in having one in the outer loop if there's not o

pgsql: Clean up sloppy coding in publicationcmds.c's OpenTableList().

2018-12-07 Thread Tom Lane
Clean up sloppy coding in publicationcmds.c's OpenTableList(). Remove dead code (which would be incorrect if it weren't dead), per report from Pan Bian. Add a CHECK_FOR_INTERRUPTS in the inner loop over child relations, because there's little point in having one in the outer loop if there's not o

pgsql: Clean up sloppy coding in publicationcmds.c's OpenTableList().

2018-12-07 Thread Tom Lane
Clean up sloppy coding in publicationcmds.c's OpenTableList(). Remove dead code (which would be incorrect if it weren't dead), per report from Pan Bian. Add a CHECK_FOR_INTERRUPTS in the inner loop over child relations, because there's little point in having one in the outer loop if there's not o

pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.

2018-12-07 Thread Tom Lane
Fix misapplication of pgstat_count_truncate to wrong relation. The stanza of ExecuteTruncate[Guts] that truncates a target table's toast relation re-used the loop local variable "rel" to reference the toast rel. This was safe enough when written, but commit d42358efb added code below that that sup

pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.

2018-12-07 Thread Tom Lane
Fix misapplication of pgstat_count_truncate to wrong relation. The stanza of ExecuteTruncate[Guts] that truncates a target table's toast relation re-used the loop local variable "rel" to reference the toast rel. This was safe enough when written, but commit d42358efb added code below that that sup

pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.

2018-12-07 Thread Tom Lane
Fix misapplication of pgstat_count_truncate to wrong relation. The stanza of ExecuteTruncate[Guts] that truncates a target table's toast relation re-used the loop local variable "rel" to reference the toast rel. This was safe enough when written, but commit d42358efb added code below that that sup

pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.

2018-12-07 Thread Tom Lane
Fix misapplication of pgstat_count_truncate to wrong relation. The stanza of ExecuteTruncate[Guts] that truncates a target table's toast relation re-used the loop local variable "rel" to reference the toast rel. This was safe enough when written, but commit d42358efb added code below that that sup

pgsql: Fix misapplication of pgstat_count_truncate to wrong relation.

2018-12-07 Thread Tom Lane
Fix misapplication of pgstat_count_truncate to wrong relation. The stanza of ExecuteTruncate[Guts] that truncates a target table's toast relation re-used the loop local variable "rel" to reference the toast rel. This was safe enough when written, but commit d42358efb added code below that that sup

pgsql: In PQprint(), write HTML table trailer before closing the output

2018-12-07 Thread Tom Lane
In PQprint(), write HTML table trailer before closing the output pipe. This is an astonishingly ancient bit of silliness, dating AFAICS to commit edb519b14 of 27-Jul-1996 which added the pipe close stanza in the wrong place. It happens to be harmless given that the code above this won't enable th

pgsql: Doc: remove obsolete statements about system OID columns in ALTE

2018-12-07 Thread Tom Lane
Doc: remove obsolete statements about system OID columns in ALTER TABLE. Missed in commit 578b22971. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1464755fc490a9911214817fe83077a3689250ab Modified Files -- doc/src/sgml/ref/alter_table.sgml | 16 ++

pgsql: Doc: document that we expect CHECK constraint conditions to be i

2018-12-07 Thread Tom Lane
Doc: document that we expect CHECK constraint conditions to be immutable. This restriction is implicit in the check-only-once implementation we use for table and domain constraints, but it wasn't spelled out anywhere, nor was there any advice about how to alter a constraint's behavior safely. Impr