pgsql: Show shared object statistics in pg_stat_database

2019-04-12 Thread Magnus Hagander
Show shared object statistics in pg_stat_database This adds a row to the pg_stat_database view with datoid 0 and datname NULL for those objects that are not in a database. This was added particularly for checksums, but we were already tracking more satistics for these objects, just not returning i

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-12 Thread Andrew Dunstan
On 4/11/19 9:56 PM, Michael Paquier wrote: > Switch TAP tests of pg_rewind to use a role with minimal permissions > > Up to now the tests of pg_rewind have been using a superuser for all the > tests (which is the default of many tests actually, and something that > ought to be reviewed) when invo

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-12 Thread Tom Lane
Andrew Dunstan writes: > jacana and bowerbird don't seem happy with this. I thought that might be an aberration, but a quick review suggests that none of the other Windows buildfarm members are running the pg_rewind test. It's fairly hard to see how we get from this patch to those failures, thou

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-12 Thread Michael Paquier
On April 13, 2019 11:59:23 AM GMT+09:00, Tom Lane wrote: >Andrew Dunstan writes: >> jacana and bowerbird don't seem happy with this. > > I thought that might be an aberration, but a quick review suggests that > none of the other Windows buildfarm members are running the pg_rewind > test. > > I

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-12 Thread Tom Lane
Michael Paquier writes: > On April 13, 2019 11:59:23 AM GMT+09:00, Tom Lane wrote: >> It's fairly hard to see how we get from this patch to those failures, >> though ... > If you look at the logs, SSPI authentication fails because there is no > user mapping for the user added by this commit in t

pgsql: Revert "Switch TAP tests of pg_rewind to use a role with minimal

2019-04-12 Thread Michael Paquier
Revert "Switch TAP tests of pg_rewind to use a role with minimal permissions" This reverts commit d4e2a84, which added a new user with limited permissions to run the TAP tests of pg_rewind. Buildfarm machine members on Windows jacana and bowerbird have been complaining about that, the new role no

Re: pgsql: Switch TAP tests of pg_rewind to use a role with minimal permiss

2019-04-12 Thread Michael Paquier
On Fri, Apr 12, 2019 at 11:54:48PM -0400, Tom Lane wrote: > Hm. Seems like that test case could also use some work so that it's > more obvious when it has connection problems. For the problem reported, the deal is that we need to add in pg_indent.conf a mapping to the new user created (as done in

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec

pgsql: Consistently test for in-use shared memory.

2019-04-12 Thread Noah Misch
Consistently test for in-use shared memory. postmaster startup scrutinizes any shared memory segment recorded in postmaster.pid, exiting if that segment matches the current data directory and has an attached process. When the postmaster.pid file was missing, a starting postmaster used weaker chec