Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-13 Thread Amit Langote
On 2019/05/11 10:25, Bruce Momjian wrote: > I struggled to talk about partitioning since there were so many > improvements. I favored a more generic item that just suggested > dramatic improvements. I have modified the text to: > > Improve performance of many operations on partitioned tabl

pgsql: postgres_fdw: Fix typo in comment.

2019-05-13 Thread Etsuro Fujita
postgres_fdw: Fix typo in comment. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/af16f0a7045da816d33d8b23045eca5c2473342c Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: postgres_fdw: Fix typo in comment.

2019-05-13 Thread Etsuro Fujita
postgres_fdw: Fix typo in comment. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7c16a2bfdcd8d477c8ff39c5eeb7d3b87fe0d60b Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: postgres_fdw: Fix typo in comment.

2019-05-13 Thread Etsuro Fujita
postgres_fdw: Fix typo in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc866941ad4583f07e5637c145f6f6ee8a573e11 Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: postgres_fdw: Fix typo in comment.

2019-05-13 Thread Etsuro Fujita
postgres_fdw: Fix typo in comment. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6ba0ff47cd9a7e86298dca3ead112eb27ae21265 Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix misuse of an integer as a bool.

2019-05-13 Thread Tom Lane
Fix misuse of an integer as a bool. pgtls_read_pending is declared to return bool, but what the underlying SSL_pending function returns is a count of available bytes. This is actually somewhat harmless if we're using C99 bools, but in the back branches it's a live bug: if the available-bytes coun

pgsql: Fix misuse of an integer as a bool.

2019-05-13 Thread Tom Lane
Fix misuse of an integer as a bool. pgtls_read_pending is declared to return bool, but what the underlying SSL_pending function returns is a count of available bytes. This is actually somewhat harmless if we're using C99 bools, but in the back branches it's a live bug: if the available-bytes coun

pgsql: Fix misuse of an integer as a bool.

2019-05-13 Thread Tom Lane
Fix misuse of an integer as a bool. pgtls_read_pending is declared to return bool, but what the underlying SSL_pending function returns is a count of available bytes. This is actually somewhat harmless if we're using C99 bools, but in the back branches it's a live bug: if the available-bytes coun

pgsql: Fix misuse of an integer as a bool.

2019-05-13 Thread Tom Lane
Fix misuse of an integer as a bool. pgtls_read_pending is declared to return bool, but what the underlying SSL_pending function returns is a count of available bytes. This is actually somewhat harmless if we're using C99 bools, but in the back branches it's a live bug: if the available-bytes coun

pgsql: Fix misuse of an integer as a bool.

2019-05-13 Thread Tom Lane
Fix misuse of an integer as a bool. pgtls_read_pending is declared to return bool, but what the underlying SSL_pending function returns is a count of available bytes. This is actually somewhat harmless if we're using C99 bools, but in the back branches it's a live bug: if the available-bytes coun

pgsql: Improve comment for att_isnull.

2019-05-13 Thread Robert Haas
Improve comment for att_isnull. The comment implies that a 1 in the null bitmap indicates a null value, but actually a 0 in the null bitmap indicates a null value. Try to be more clear. Patch by me; proposed wording reviewed by Alvaro Herrera and Tom Lane. Discussion: http://postgr.es/m/CA+Tgmo

pgsql: Don't leave behind junk nbtree pages during split.

2019-05-13 Thread Peter Geoghegan
Don't leave behind junk nbtree pages during split. Commit 8fa30f906be reduced the elevel of a number of "can't happen" _bt_split() errors from PANIC to ERROR. At the same time, the new right page buffer for the split could continue to be acquired well before the critical section. This was possib

pgsql: Don't leave behind junk nbtree pages during split.

2019-05-13 Thread Peter Geoghegan
Don't leave behind junk nbtree pages during split. Commit 8fa30f906be reduced the elevel of a number of "can't happen" _bt_split() errors from PANIC to ERROR. At the same time, the new right page buffer for the split could continue to be acquired well before the critical section. This was possib

pgsql: Fix logical replication's ideas about which type OIDs are built-

2019-05-13 Thread Tom Lane
Fix logical replication's ideas about which type OIDs are built-in. Only hand-assigned type OIDs should be presumed to match across different PG servers; those assigned during genbki.pl or during initdb are likely to change due to addition or removal of unrelated objects. This means that the cuto

pgsql: Fix logical replication's ideas about which type OIDs are built-

2019-05-13 Thread Tom Lane
Fix logical replication's ideas about which type OIDs are built-in. Only hand-assigned type OIDs should be presumed to match across different PG servers; those assigned during genbki.pl or during initdb are likely to change due to addition or removal of unrelated objects. This means that the cuto

pgsql: Improve commentary about hack in is_publishable_class().

2019-05-13 Thread Tom Lane
Improve commentary about hack in is_publishable_class(). The FirstNormalObjectId test here is a kluge that needs to go away, but the only substitute we can think of is to add a column to pg_class, which will take more work than can be handled right now. Add some commentary in the meanwhile. Disc

pgsql: Fix logical replication's ideas about which type OIDs are built-

2019-05-13 Thread Tom Lane
Fix logical replication's ideas about which type OIDs are built-in. Only hand-assigned type OIDs should be presumed to match across different PG servers; those assigned during genbki.pl or during initdb are likely to change due to addition or removal of unrelated objects. This means that the cuto

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Doc: Refer to line pointers as item identifiers.

2019-05-13 Thread Peter Geoghegan
Doc: Refer to line pointers as item identifiers. An upcoming HEAD-only patch will standardize the terminology around ItemIdData variables/line pointers, ending the practice of referring to them as "item pointers". Make the "Database Page Layout" docs consistent with the new policy. The term "ite

pgsql: Standardize ItemIdData terminology.

2019-05-13 Thread Peter Geoghegan
Standardize ItemIdData terminology. The term "item pointer" should not be used to refer to ItemIdData variables, since that is needlessly ambiguous. Only ItemPointerData/ItemPointer variables should be called item pointers. To fix, establish the convention that ItemIdData variables should always

pgsql: Fix duplicated words in comments

2019-05-13 Thread Michael Paquier
Fix duplicated words in comments Author: Stephen Amell Discussion: https://postgr.es/m/539fa271-21b3-777e-a468-d96cffe9c...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e19929ea29668f3d01280262e407b93042c959a Modified Files -- src/backend/

pgsql: doc: properly attibute PG 12 pgbench release note item

2019-05-13 Thread Bruce Momjian
doc: properly attibute PG 12 pgbench release note item Reported-by: Fabien COELHO Discussion: https://postgr.es/m/alpine.DEB.2.21.1905130839140.13487@lancre Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5d971565a7993ba8dcd06d34d1387af48fdbd034 Modified Files --

pgsql: doc: improve wording of PG 12 releaase note partition item

2019-05-13 Thread Bruce Momjian
doc: improve wording of PG 12 releaase note partition item Reported-by: Amit Langote Discussion: https://postgr.es/m/d5267ae5-bd4a-3e96-c21b-56bfa9fec...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f4125278e3c92d8cdd83c77d0b54f468ee81c750 Modifi

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-13 Thread Bruce Momjian
On Mon, May 13, 2019 at 04:01:36PM +0900, Amit Langote wrote: > On 2019/05/11 10:25, Bruce Momjian wrote: > > I struggled to talk about partitioning since there were so many > > improvements. I favored a more generic item that just suggested > > dramatic improvements. I have modified the text to:

pgsql: doc: Update OID item in PG 12 release notes

2019-05-13 Thread Bruce Momjian
doc: Update OID item in PG 12 release notes Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190513174759.ge23...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0b62f0f2552d895301fdae56aa839c1eaae24a3a Modified Files -- doc/