pgsql: doc: Fix typo

2019-07-25 Thread Peter Eisentraut
doc: Fix typo Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2e60117aa9152ca11b54e95a41f72f71a2387f33 Modified Files -- doc/src/sgml/libpq.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Fix typo

2019-07-25 Thread Peter Eisentraut
doc: Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/35a34e62ed4974b9178a2dc924d645d6a12e7e9a Modified Files -- doc/src/sgml/libpq.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Fix contrib/sepgsql test policy to work with latest SELinux rele

2019-07-25 Thread Tom Lane
Fix contrib/sepgsql test policy to work with latest SELinux releases. As of Fedora 30, it seems that the system-provided macros for setting up user privileges in SELinux policies don't grant the ability to read /etc/passwd, as they formerly did. This restriction breaks psql (which tries to use ge

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
Honor MSVC WindowsSDKVersion if set Add a line to the project file setting the target SDK. Otherwise, in for example VS2017, if the default but optional 8.1 SDK is not installed the build will fail. Patch from Peifeng Qiu, slightly edited by me. Discussion: https://postgr.es/m/CABmtVJhw1boP_bd4

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

pgsql: Fix failures to ignore \r when reading Windows-style newlines.

2019-07-25 Thread Tom Lane
Fix failures to ignore \r when reading Windows-style newlines. libpq failed to ignore Windows-style newlines in connection service files. This normally wasn't a problem on Windows itself, because fgets() would convert \r\n to just \n. But if libpq were running inside a program that changes the de

Re: pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Tom Lane
Andrew Dunstan writes: > Honor MSVC WindowsSDKVersion if set Hmm, dory seems unhappy with this: syntax error at C:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\src\tools\msvc/MSBuildProject.pm line 50, near ", =~" BEGIN not safe after errors--compilation aborted at C:\pgbuildfarm\pgbuildroot\HEAD

Re: pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
On 7/25/19 1:18 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Honor MSVC WindowsSDKVersion if set > Hmm, dory seems unhappy with this: > > syntax error at > C:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\src\tools\msvc/MSBuildProject.pm > line 50, near ", =~" > BEGIN not safe after errors--comp

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3f1c6d0482e2e19e634b5f13fc2bda5ca805f8d9 Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ed304d1e26552c5fdc2fdb0dcac9335f7f33e86c Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e465d9d4058884e848571f3a59c541feb030a7b2 Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2453704673469ffd34ed13a642e3edc936f5a24 Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cb9bb15783f2d6b2e66f7c18bc35e849df623dfa Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7ea91ae1980d52655837e7e3e563eb75eecbe29d Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix syntax error in commit 20e99cddd.

2019-07-25 Thread Tom Lane
Fix syntax error in commit 20e99cddd. Per buildfarm. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4583605e6d1f2b95a61dfe0c1fdfba99a88e3c4a Modified Files -- src/tools/msvc/MSBuildProject.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Tom Lane
I wrote: > Andrew Dunstan writes: >> Honor MSVC WindowsSDKVersion if set > Hmm, dory seems unhappy with this: Looking closer, it seems to be just a stray comma, so I fixed that. regards, tom lane

Re: pgsql: Honor MSVC WindowsSDKVersion if set

2019-07-25 Thread Andrew Dunstan
On 7/25/19 2:43 PM, Tom Lane wrote: > I wrote: >> Andrew Dunstan writes: >>> Honor MSVC WindowsSDKVersion if set >> Hmm, dory seems unhappy with this: > Looking closer, it seems to be just a stray comma, so I fixed that. > > Thanks for fixing cheers andrew -- And

pgsql: Fix slot type handling for Agg nodes performing internal sorts.

2019-07-25 Thread Andres Freund
Fix slot type handling for Agg nodes performing internal sorts. Since 15d8f8312 we assert that - and since 7ef04e4d2cb2, 4da597edf1 rely on - the slot type for an expression's ecxt_{outer,inner,scan}tuple not changing, unless explicitly flagged as such. That allows to either skip deforming (for a

pgsql: Fix slot type handling for Agg nodes performing internal sorts.

2019-07-25 Thread Andres Freund
Fix slot type handling for Agg nodes performing internal sorts. Since 15d8f8312 we assert that - and since 7ef04e4d2cb2, 4da597edf1 rely on - the slot type for an expression's ecxt_{outer,inner,scan}tuple not changing, unless explicitly flagged as such. That allows to either skip deforming (for a

pgsql: Add missing (COSTS OFF) to EXPLAIN added in previous commit.

2019-07-25 Thread Andres Freund
Add missing (COSTS OFF) to EXPLAIN added in previous commit. Backpatch: 12-, like the previous commit Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f63d9e68d4132a4608e9f50782aaacbe5ed6f57a Modified Files -- src/test/regress/expected/groupingsets.out |

pgsql: Add missing (COSTS OFF) to EXPLAIN added in previous commit.

2019-07-25 Thread Andres Freund
Add missing (COSTS OFF) to EXPLAIN added in previous commit. Backpatch: 12-, like the previous commit Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c4944a93eb526f3799a36f30d46d6e765108b2b4 Modified Files -- src/test/regress/expected/groupingset

pgsql: Fix LDAP test instability.

2019-07-25 Thread Thomas Munro
Fix LDAP test instability. After starting slapd, wait until it can accept a connection before beginning the real test work. This avoids occasional test failures. Back-patch to 11, where the LDAP tests arrived. Author: Thomas Munro Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/2019

pgsql: Fix LDAP test instability.

2019-07-25 Thread Thomas Munro
Fix LDAP test instability. After starting slapd, wait until it can accept a connection before beginning the real test work. This avoids occasional test failures. Back-patch to 11, where the LDAP tests arrived. Author: Thomas Munro Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/2019

pgsql: Fix LDAP test instability.

2019-07-25 Thread Thomas Munro
Fix LDAP test instability. After starting slapd, wait until it can accept a connection before beginning the real test work. This avoids occasional test failures. Back-patch to 11, where the LDAP tests arrived. Author: Thomas Munro Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/2019

pgsql: doc: PG 12 relnotes, add item - pg_test_fsync fix on Windows

2019-07-25 Thread Bruce Momjian
doc: PG 12 relnotes, add item - pg_test_fsync fix on Windows Reported-by: Laurenz Albe Discussion: https://postgr.es/m/39fd196ca3af345f67595087519268d9da6891b3.ca...@cybertec.at Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/551394f

pgsql: doc: PG 12 relnotes - add item about amcheck index root check

2019-07-25 Thread Bruce Momjian
doc: PG 12 relnotes - add item about amcheck index root check Reported-by: Peter Geoghegan Discussion: https://postgr.es/m/lgbt2ncb7tidsndk0exhtkmogljj5ro52hqxigp8...@mail.gmail.com Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ba2