pgsql: Improve documentation of pageinspect

2019-08-23 Thread Michael Paquier
Improve documentation of pageinspect This adds a section for heap-related functions. These were previously mixed with functions having a more general purpose, leading to confusion. While on it, add a query example for fsm_page_contents. Backpatch down to 10, where b5e3942 introduced the subsect

pgsql: Improve documentation of pageinspect

2019-08-23 Thread Michael Paquier
Improve documentation of pageinspect This adds a section for heap-related functions. These were previously mixed with functions having a more general purpose, leading to confusion. While on it, add a query example for fsm_page_contents. Backpatch down to 10, where b5e3942 introduced the subsect

pgsql: Improve documentation of pageinspect

2019-08-23 Thread Michael Paquier
Improve documentation of pageinspect This adds a section for heap-related functions. These were previously mixed with functions having a more general purpose, leading to confusion. While on it, add a query example for fsm_page_contents. Backpatch down to 10, where b5e3942 introduced the subsect

pgsql: Improve documentation of pageinspect

2019-08-23 Thread Michael Paquier
Improve documentation of pageinspect This adds a section for heap-related functions. These were previously mixed with functions having a more general purpose, leading to confusion. While on it, add a query example for fsm_page_contents. Backpatch down to 10, where b5e3942 introduced the subsect

pgsql: Remove dry-run mode from isolationtester

2019-08-23 Thread Michael Paquier
Remove dry-run mode from isolationtester The original purpose of the dry-run mode is to be able to print all the possible permutations from a spec file, but it has become less useful since isolation tests has improved regarding deadlock detection as one step not wanted by the author could block in

pgsql: Detect unused steps in isolation specs and do some cleanup

2019-08-23 Thread Michael Paquier
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the spe

Re: pgsql: Detect unused steps in isolation specs and do some cleanup

2019-08-23 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > Detect unused steps in isolation specs and do some cleanup > > This is useful for developers to find out if an isolation spec is > over-engineered or if it needs more work by warning at the end of a > test run if a step is not used, gene

pgsql: Explain subtlety in nbtree locking protocol.

2019-08-23 Thread Peter Geoghegan
Explain subtlety in nbtree locking protocol. The Postgres approach to coupling locks during an ascent of the tree is slightly different to the approach taken by Lehman and Yao. Add a new paragraph to the "Differences to the Lehman & Yao algorithm" section of the nbtree README that explains the si

pgsql: Do more cleanup of isolation tests for test_decoding

2019-08-23 Thread Michael Paquier
Do more cleanup of isolation tests for test_decoding 989d23b has caused its tests to be broken as the module defines unused steps, turning the buildfarm red. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/06fdc4e4d33c40dbf886565336574da5566878f4 Modified Files ---

Re: pgsql: Detect unused steps in isolation specs and do some cleanup

2019-08-23 Thread Michael Paquier
On Fri, Aug 23, 2019 at 11:07:49PM -0400, Stephen Frost wrote: > Buildfarm didn't particularly like this. Thanks, I have noticed that. The problem should be fixed now thanks to 06fdc4e. -- Michael signature.asc Description: PGP signature