pgsql: Move configure --disable-float8-byval to pg_config_manual.h

2019-11-27 Thread Peter Eisentraut
Move configure --disable-float8-byval to pg_config_manual.h This build option was once useful to maintain compatibility with version-0 functions, but those are no longer supported, so this option is no longer useful for end users. We keep the option available to developers in pg_config_manual.h s

pgsql: Revert "Close stdin where it's not needed in TestLib.pm procedur

2019-11-27 Thread Andrew Dunstan
Revert "Close stdin where it's not needed in TestLib.pm procedures" This reverts commits 9af34f3c6b and 792dba73c8. The code has been found not to be portable. Discussion: https://postgr.es/m/2658c496-f885-02db-13bb-228423782...@2ndquadrant.com Branch -- master Details --- https://git

Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo

2019-11-27 Thread Andrew Dunstan
On 11/26/19 9:17 PM, Andrew Dunstan wrote: > On 11/25/19 11:41 PM, Michael Paquier wrote: >> Hi Andrew, >> >> On Sun, Nov 24, 2019 at 11:53:31PM +, Andrew Dunstan wrote: >>> Use native methods to open input in TestLib::slurp_file on Windows. >>> >>> It is hoped that this will avoid some error

pgsql: Don't use native methods in TestLib::slurp_file on Msys

2019-11-27 Thread Andrew Dunstan
Don't use native methods in TestLib::slurp_file on Msys Commit 114541d58e has upset some buildfarm members running Msys, that weren't previously having problems, so the use of native Windows methods to open files is restricted by this patch to only MSVC builds. Branch -- master Details -

pgsql: pg_upgrade: improve instructions for fixing incompatible isn use

2019-11-27 Thread Bruce Momjian
pg_upgrade: improve instructions for fixing incompatible isn use This clarifies instructions on how to dump/reload databases that use incompatible isn versions. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20191114190652.GA23586@alvherre.pgsql Reviewed-by: Daniel Gustafsson Bac

pgsql: pg_upgrade: adjust error paragraph width to be consistent

2019-11-27 Thread Bruce Momjian
pg_upgrade: adjust error paragraph width to be consistent Previously these error paragraphs were too wide. Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/60b35b7f1ea1d5cd17805e30299fd21616855b7d Modified Files -- src/bin/pg_upgr

pgsql: Move pump_until to TestLib.pm.

2019-11-27 Thread Amit Kapila
Move pump_until to TestLib.pm. The subroutine pump_until provides the functionality to poll until the given string is matched, or a timeout occurs.  This can be used from other places as well, so moving it to TestLib.pm.  The immediate need is for an upcoming regression test patch for dropdb utili

pgsql: Add tests for '-f' option in dropdb utility.

2019-11-27 Thread Amit Kapila
Add tests for '-f' option in dropdb utility. This will test that the force option works when there is an active backend connected to the database being dropped. Author: Pavel Stehule and Vignesh C Reviewed-by: Amit Kapila and Vignesh C Discussion: https://postgr.es/m/cap_rwwmljjbn70vlozfpxgw3xd7