Re: pgsql: Handle lack of DSM slots in parallel btree build.

2020-02-03 Thread Peter Geoghegan
On Thu, Jan 30, 2020 at 2:34 PM Thomas Munro wrote: > Handle lack of DSM slots in parallel btree build. > > If no DSM slots are available, a ParallelContext can still be > created, but its seg pointer is NULL. Teach parallel btree build > to cope with that by falling back to a regular non-paralle

Re: pgsql: Handle lack of DSM slots in parallel btree build.

2020-02-03 Thread Thomas Munro
Hi Peter, On Tue, Feb 4, 2020 at 9:13 AM Peter Geoghegan wrote: > On Thu, Jan 30, 2020 at 2:34 PM Thomas Munro wrote: > > Handle lack of DSM slots in parallel btree build. > > > > If no DSM slots are available, a ParallelContext can still be > > created, but its seg pointer is NULL. Teach paral

pgsql: Add missing break out seqscan loop in logical replication

2020-02-03 Thread Alvaro Herrera
Add missing break out seqscan loop in logical replication When replica identity is FULL (an admittedly unusual case), the loop that searches for tuples in execReplication.c didn't stop scanning the table when once a matching tuple was found. Add the missing 'break'. Note slight behavior change:

pgsql: Add missing break out seqscan loop in logical replication

2020-02-03 Thread Alvaro Herrera
Add missing break out seqscan loop in logical replication When replica identity is FULL (an admittedly unusual case), the loop that searches for tuples in execReplication.c didn't stop scanning the table when once a matching tuple was found. Add the missing 'break'. Note slight behavior change:

pgsql: Add missing break out seqscan loop in logical replication

2020-02-03 Thread Alvaro Herrera
Add missing break out seqscan loop in logical replication When replica identity is FULL (an admittedly unusual case), the loop that searches for tuples in execReplication.c didn't stop scanning the table when once a matching tuple was found. Add the missing 'break'. Note slight behavior change:

pgsql: Add missing break out seqscan loop in logical replication

2020-02-03 Thread Alvaro Herrera
Add missing break out seqscan loop in logical replication When replica identity is FULL (an admittedly unusual case), the loop that searches for tuples in execReplication.c didn't stop scanning the table when once a matching tuple was found. Add the missing 'break'. Note slight behavior change:

pgsql: Fix fuzzy error handling in pg_basebackup when opening gzFile

2020-02-03 Thread Michael Paquier
Fix fuzzy error handling in pg_basebackup when opening gzFile First, this code did not bother checking for a failure when calling dup(). Then, per zlib, gzerror() returns NULL for a NULL input, which can happen if passing down to gzdopen() an invalid file descriptor or if there was an allocation