pgsql: pg_dump: Further reorganize getTableAttrs()

2020-07-09 Thread Peter Eisentraut
pg_dump: Further reorganize getTableAttrs() After further discussion after daa9fe8a5264a3f192efa5ddee8fb011ad9da365, reorder the version-specific sections from oldest to newest. Also, remove the variable assignments from PQfnumber() to reduce vertical space. Reviewed-by: Fabien COELHO Discussio

pgsql: Further tighten Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Further tighten Windows CRLF conversion in our TAP test scripts. Buildfarm results now imply that Perl's IPC::Run does CRLF conversion for us if we're using native Perl, but not when using MSys Perl. Restrict the conversions done by PostgresNode.pm to act only in the latter case. (Similar convers

pgsql: Fix pg_current_logfile() to not emit a carriage return on Window

2020-07-09 Thread Tom Lane
Fix pg_current_logfile() to not emit a carriage return on Windows. Due to not having our signals straight about CRLF vs. LF line termination, the output of pg_current_logfile() included a trailing \r on Windows. To fix, force the file descriptor it uses into text mode. While here, move a couple

pgsql: Fix pg_current_logfile() to not emit a carriage return on Window

2020-07-09 Thread Tom Lane
Fix pg_current_logfile() to not emit a carriage return on Windows. Due to not having our signals straight about CRLF vs. LF line termination, the output of pg_current_logfile() included a trailing \r on Windows. To fix, force the file descriptor it uses into text mode. While here, move a couple

pgsql: Fix pg_current_logfile() to not emit a carriage return on Window

2020-07-09 Thread Tom Lane
Fix pg_current_logfile() to not emit a carriage return on Windows. Due to not having our signals straight about CRLF vs. LF line termination, the output of pg_current_logfile() included a trailing \r on Windows. To fix, force the file descriptor it uses into text mode. While here, move a couple

pgsql: Fix pg_current_logfile() to not emit a carriage return on Window

2020-07-09 Thread Tom Lane
Fix pg_current_logfile() to not emit a carriage return on Windows. Due to not having our signals straight about CRLF vs. LF line termination, the output of pg_current_logfile() included a trailing \r on Windows. To fix, force the file descriptor it uses into text mode. While here, move a couple

pgsql: Fix pg_current_logfile() to not emit a carriage return on Window

2020-07-09 Thread Tom Lane
Fix pg_current_logfile() to not emit a carriage return on Windows. Due to not having our signals straight about CRLF vs. LF line termination, the output of pg_current_logfile() included a trailing \r on Windows. To fix, force the file descriptor it uses into text mode. While here, move a couple

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-09 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. Back-patch commits 91bdf499b and ffb4cee43, so that all branches agree on when and how to do Windows CRLF conversion. This should close the referenced thread. Thanks to Andrew Dunstan for discussion/review. Discussion: https://postgr.e

Re: pgsql: Remove reset of testtablespace from pg_regress on Windows

2020-07-09 Thread Andrew Dunstan
On 6/17/20 9:40 PM, Michael Paquier wrote: > Remove reset of testtablespace from pg_regress on Windows > > > This patch has carefully removed the ability to run the regression tests as a Windows administrative user, as I just discovered. This was the whole point of commit ce5d3424d6. I assume

pgsql: Remove WARNING message from brin_desummarize_range

2020-07-09 Thread Alvaro Herrera
Remove WARNING message from brin_desummarize_range This message was being emitted on the grounds that only crashed summarization could cause it, but in reality even an aborted vacuum could do it ... which makes it way too noisy, particularly since it shows up in regression tests and makes them die

pgsql: Remove WARNING message from brin_desummarize_range

2020-07-09 Thread Alvaro Herrera
Remove WARNING message from brin_desummarize_range This message was being emitted on the grounds that only crashed summarization could cause it, but in reality even an aborted vacuum could do it ... which makes it way too noisy, particularly since it shows up in regression tests and makes them die

pgsql: Remove WARNING message from brin_desummarize_range

2020-07-09 Thread Alvaro Herrera
Remove WARNING message from brin_desummarize_range This message was being emitted on the grounds that only crashed summarization could cause it, but in reality even an aborted vacuum could do it ... which makes it way too noisy, particularly since it shows up in regression tests and makes them die

pgsql: Remove WARNING message from brin_desummarize_range

2020-07-09 Thread Alvaro Herrera
Remove WARNING message from brin_desummarize_range This message was being emitted on the grounds that only crashed summarization could cause it, but in reality even an aborted vacuum could do it ... which makes it way too noisy, particularly since it shows up in regression tests and makes them die

pgsql: Remove WARNING message from brin_desummarize_range

2020-07-09 Thread Alvaro Herrera
Remove WARNING message from brin_desummarize_range This message was being emitted on the grounds that only crashed summarization could cause it, but in reality even an aborted vacuum could do it ... which makes it way too noisy, particularly since it shows up in regression tests and makes them die

Re: pgsql: Remove reset of testtablespace from pg_regress on Windows

2020-07-09 Thread Michael Paquier
On Thu, Jul 09, 2020 at 07:28:02PM -0400, Andrew Dunstan wrote: > This patch has carefully removed the ability to run the regression tests > as a Windows administrative user, as I just discovered. This was the > whole point of commit ce5d3424d6. > > I assume the testing referred to above was not a

Re: pgsql: Remove reset of testtablespace from pg_regress on Windows

2020-07-09 Thread Andrew Dunstan
On 7/9/20 9:02 PM, Michael Paquier wrote: > On Thu, Jul 09, 2020 at 07:28:02PM -0400, Andrew Dunstan wrote: >> This patch has carefully removed the ability to run the regression tests >> as a Windows administrative user, as I just discovered. This was the >> whole point of commit ce5d3424d6. >> >

pgsql: Log the location field before any backtrace

2020-07-09 Thread Peter Eisentraut
Log the location field before any backtrace This order makes more sense because the location is effectively at the lowest level of the backtrace. Discussion: https://www.postgresql.org/message-id/flat/90f5fa04-c410-a54e-9449-aa3749fb7972%402ndquadrant.com Branch -- REL_13_STABLE Details --

pgsql: Log the location field before any backtrace

2020-07-09 Thread Peter Eisentraut
Log the location field before any backtrace This order makes more sense because the location is effectively at the lowest level of the backtrace. Discussion: https://www.postgresql.org/message-id/flat/90f5fa04-c410-a54e-9449-aa3749fb7972%402ndquadrant.com Branch -- master Details --- h