pgsql: Add some more numeric test coverage

2020-09-09 Thread Peter Eisentraut
Add some more numeric test coverage max(numeric) wasn't tested at all, min(numeric) was only used by some unrelated tests. Add explicit tests with the other numeric aggregate functions. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fe2bf8f81096ea1b7b2fc58501309fc

pgsql: Add missing quote in docs

2020-09-09 Thread Magnus Hagander
Add missing quote in docs Mistake in commit 68b603e1a9. Reported-by: Ian Barwick Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1bf0b9c5f58c61c160519a77a8f9dd24cea68b32 Modified Files -- doc/src/sgml/file-fdw.sgml | 2 +- 1 file changed, 1 inser

pgsql: Add missing quote in docs

2020-09-09 Thread Magnus Hagander
Add missing quote in docs Mistake in commit 68b603e1a9. Reported-by: Ian Barwick Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/60df530c571a8a5fbae82dc82e4931bb6325ddc0 Modified Files -- doc/src/sgml/file-fdw.sgml | 2 +- 1 file changed, 1 insertion(+)

pgsql: Minor fixes in docs and error messages.

2020-09-09 Thread Tom Lane
Minor fixes in docs and error messages. Alexander Lakhin Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f3e1e6619655bf219131d93ec85348cad75c7f12 Modified Files -- doc/src/s

pgsql: Minor fixes in docs and error messages.

2020-09-09 Thread Tom Lane
Minor fixes in docs and error messages. Alexander Lakhin Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa33187164e1d8571f1568f0470aaace8f791876 Modified Files -- do

pgsql: Doc: adjust documentation related to index support functions.

2020-09-09 Thread Tom Lane
Doc: adjust documentation related to index support functions. Commit 15cb2bd27 neglected to make the running text match the tables, leaving the reader with the strong impression that we cannot count. Also, don't drop an unrelated para between a table and the para describing it. Branch -- mas

pgsql: Doc: adjust documentation related to index support functions.

2020-09-09 Thread Tom Lane
Doc: adjust documentation related to index support functions. Commit 15cb2bd27 neglected to make the running text match the tables, leaving the reader with the strong impression that we cannot count. Also, don't drop an unrelated para between a table and the para describing it. Branch -- REL

pgsql: Expose internal function for converting int64 to numeric

2020-09-09 Thread Peter Eisentraut
Expose internal function for converting int64 to numeric Existing callers had to take complicated detours via DirectFunctionCall1(). This simplifies a lot of code. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/[email protected] Br

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

pgsql: Make archiver's SIGQUIT handler exit via _exit().

2020-09-09 Thread Tom Lane
Make archiver's SIGQUIT handler exit via _exit(). Commit 8e19a8264 changed the SIGQUIT handlers of almost all server processes not to run atexit callbacks. The archiver process was skipped, perhaps because it's not connected to shared memory; but it's just as true here that running atexit callbac

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-09 Thread Tom Lane
Amit Kapila writes: > Implement streaming mode in ReorderBuffer. Looks like this test is somewhat unstable still: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2020-09-09%2003%3A42%3A19 diff -U3 /home/andres/build/buildfarm/HEAD/pgsql.build/../pgsql/contrib/test_decoding/exp

pgsql: Fix rd_firstRelfilenodeSubid for nailed relations, in parallel w

2020-09-09 Thread Noah Misch
Fix rd_firstRelfilenodeSubid for nailed relations, in parallel workers. Move applicable code out of RelationBuildDesc(), which nailed relations bypass. Non-assert builds experienced no known problems. Back-patch to v13, where commit c6b92041d38512a4176ed76ad06f713d2e6c01a8 introduced rd_firstRel

pgsql: Fix rd_firstRelfilenodeSubid for nailed relations, in parallel w

2020-09-09 Thread Noah Misch
Fix rd_firstRelfilenodeSubid for nailed relations, in parallel workers. Move applicable code out of RelationBuildDesc(), which nailed relations bypass. Non-assert builds experienced no known problems. Back-patch to v13, where commit c6b92041d38512a4176ed76ad06f713d2e6c01a8 introduced rd_firstRel

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-09 Thread Amit Kapila
On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > Amit Kapila writes: > > Implement streaming mode in ReorderBuffer. > > Looks like this test is somewhat unstable still: > > Thanks for pointing out. I'll analyze and share my findings. -- With Regards, Amit Kapila.

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a4c0dbc447c7c42e1

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b3d89b7a889614a5a

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/25ff747721a5f4d38

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/447c1cb2f67fd6941

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aad546bd0a51059aafe44e8c

pgsql: doc: Fix some grammar and inconsistencies

2020-09-09 Thread Michael Paquier
doc: Fix some grammar and inconsistencies Some comments are fixed while on it. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d56d33052183ca57c