pgsql: Make the standby server promptly handle interrupt signals.

2020-11-16 Thread Fujii Masao
Make the standby server promptly handle interrupt signals. This commit changes the startup process in the standby server so that it handles the interrupt signals after waiting for wal_retrieve_retry_interval on the latch and resetting it, before entering another wait on the latch. This change caus

pgsql: Remove code handling removed deprecated containment operators

2020-11-16 Thread Peter Eisentraut
Remove code handling removed deprecated containment operators This removes the code that was there for handling the operators removed by 2f70fdb0644c32c4154236c2b5c241bec92eac5e. Discussion: https://www.postgresql.org/message-id/flat/20201027032511.gf9...@telsasoft.com Branch -- master Det

pgsql: Normalize comment in empty grammar rules

2020-11-16 Thread Peter Eisentraut
Normalize comment in empty grammar rules Change lower case /* empty */ to /* EMPTY */ for consistency with the majority. Discussion: https://www.postgresql.org/message-id/flat/e9eed669-e32d-6919-fed4-acc0daea857b%40enterprisedb.com Branch -- master Details --- https://git.postgresql.or

pgsql: Fix typo

2020-11-16 Thread Alvaro Herrera
Fix typo Introduced in 90fdc259866e; backpatch to 12. Author: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b3e7c202b79e4d6bce6a65c957fe7f813d5138f8 Modified Files --

pgsql: Fix typo

2020-11-16 Thread Alvaro Herrera
Fix typo Introduced in 90fdc259866e; backpatch to 12. Author: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bcbd7713324798d5a74ca640c6cf6c439bda22e4 Modified Files -

pgsql: Fix typo

2020-11-16 Thread Alvaro Herrera
Fix typo Introduced in 90fdc259866e; backpatch to 12. Author: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89e0ee9a7bada0101e1dff175cd002d16a364f94 Modified Files --

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/comm

pgsql: doc: improve wording of the need for analyze of exp. indexes

2020-11-16 Thread Bruce Momjian
doc: improve wording of the need for analyze of exp. indexes This is a followup commit on 3370207986. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20201112211143.gl30...@telsasoft.com Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/

pgsql: doc: adjust expression index analyze working some more

2020-11-16 Thread Bruce Momjian
doc: adjust expression index analyze working some more This applies the fix bcbd771332 to skipped branches. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Backpatch-through: 9.5-11 Branch -- REL_11_STABLE Details --- https://git.p

pgsql: doc: adjust expression index analyze working some more

2020-11-16 Thread Bruce Momjian
doc: adjust expression index analyze working some more This applies the fix bcbd771332 to skipped branches. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Backpatch-through: 9.5-11 Branch -- REL_10_STABLE Details --- https://git.p

pgsql: doc: adjust expression index analyze working some more

2020-11-16 Thread Bruce Momjian
doc: adjust expression index analyze working some more This applies the fix bcbd771332 to skipped branches. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Backpatch-through: 9.5-11 Branch -- REL9_6_STABLE Details --- https://git.p

pgsql: doc: adjust expression index analyze working some more

2020-11-16 Thread Bruce Momjian
doc: adjust expression index analyze working some more This applies the fix bcbd771332 to skipped branches. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/e92b3fba98a0c0f7afc0a2a37e765...@xs4all.nl Backpatch-through: 9.5-11 Branch -- REL9_5_STABLE Details --- https://git.p

pgsql: Remove unused and deprecated strategy numbers from BRIN code

2020-11-16 Thread Peter Eisentraut
Remove unused and deprecated strategy numbers from BRIN code These were dead code. Discussion: https://www.postgresql.org/message-id/flat/20201027032511.gf9...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d93ccdea1d447ab7e8c48797153ce58b051f1a37

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff

Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h

2020-11-16 Thread Bruce Momjian
On Thu, Nov 12, 2020 at 06:15:51PM -0500, Bruce Momjian wrote: > On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote: > > On 2020-Nov-12, Bruce Momjian wrote: > > > > > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h > > > > > > These files are in compiled directories an

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: clarify how to find pg_type_d.h in the install tree

2020-11-16 Thread Bruce Momjian
doc: clarify how to find pg_type_d.h in the install tree Followup to patch 152ed04799. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20201112202900.GA28098@alvherre.pgsql Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8ad06b

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL_13_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL_10_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL_11_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- REL_12_STABLE Details -

pgsql: doc: update bgwriter description

2020-11-16 Thread Bruce Momjian
doc: update bgwriter description This clarifies exactly what the bgwriter does, which should help with tuning. Reported-by: Chris Wilson Discussion: https://postgr.es/m/160399562040.7809.7335281028960123...@wrigleys.postgresql.org Backpatch-through: 9.5 Branch -- master Details ---

pgsql: Use "true" not "TRUE" in one ICU function call.

2020-11-16 Thread Tom Lane
Use "true" not "TRUE" in one ICU function call. This was evidently missed in commit 6337865f3, which generally did s/TRUE/true/ everywhere. It escaped notice up to now because ICU versions before ICU 68 provided definitions of "TRUE" and "FALSE" regardless. With ICU 68, it fails to compile. Per

pgsql: Use "true" not "TRUE" in one ICU function call.

2020-11-16 Thread Tom Lane
Use "true" not "TRUE" in one ICU function call. This was evidently missed in commit 6337865f3, which generally did s/TRUE/true/ everywhere. It escaped notice up to now because ICU versions before ICU 68 provided definitions of "TRUE" and "FALSE" regardless. With ICU 68, it fails to compile. Per

pgsql: Use "true" not "TRUE" in one ICU function call.

2020-11-16 Thread Tom Lane
Use "true" not "TRUE" in one ICU function call. This was evidently missed in commit 6337865f3, which generally did s/TRUE/true/ everywhere. It escaped notice up to now because ICU versions before ICU 68 provided definitions of "TRUE" and "FALSE" regardless. With ICU 68, it fails to compile. Per

pgsql: Use "true" not "TRUE" in one ICU function call.

2020-11-16 Thread Tom Lane
Use "true" not "TRUE" in one ICU function call. This was evidently missed in commit 6337865f3, which generally did s/TRUE/true/ everywhere. It escaped notice up to now because ICU versions before ICU 68 provided definitions of "TRUE" and "FALSE" regardless. With ICU 68, it fails to compile. Per

pgsql: Do not return NULL for error cases in satisfies_hash_partition()

2020-11-16 Thread Tom Lane
Do not return NULL for error cases in satisfies_hash_partition(). Since this function is used as a CHECK constraint condition, returning NULL is tantamount to returning TRUE, which would have the effect of letting in a row that doesn't satisfy the hash condition. Admittedly, the cases for which th

pgsql: Do not return NULL for error cases in satisfies_hash_partition()

2020-11-16 Thread Tom Lane
Do not return NULL for error cases in satisfies_hash_partition(). Since this function is used as a CHECK constraint condition, returning NULL is tantamount to returning TRUE, which would have the effect of letting in a row that doesn't satisfy the hash condition. Admittedly, the cases for which th

pgsql: Do not return NULL for error cases in satisfies_hash_partition()

2020-11-16 Thread Tom Lane
Do not return NULL for error cases in satisfies_hash_partition(). Since this function is used as a CHECK constraint condition, returning NULL is tantamount to returning TRUE, which would have the effect of letting in a row that doesn't satisfy the hash condition. Admittedly, the cases for which th

pgsql: Do not return NULL for error cases in satisfies_hash_partition()

2020-11-16 Thread Tom Lane
Do not return NULL for error cases in satisfies_hash_partition(). Since this function is used as a CHECK constraint condition, returning NULL is tantamount to returning TRUE, which would have the effect of letting in a row that doesn't satisfy the hash condition. Admittedly, the cases for which th

pgsql: Rename PGPROC->vacuumFlags to statusFlags

2020-11-16 Thread Alvaro Herrera
Rename PGPROC->vacuumFlags to statusFlags With more flags associated to a PGPROC entry that are not related to vacuum (currently existing or planned), the name "statusFlags" describes its purpose better. (The same is done to the mirroring PROC_HDR->vacuumFlags.) No functional changes in this com

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Don't Insert() a VFD entry until it's fully built.

2020-11-16 Thread Tom Lane
Don't Insert() a VFD entry until it's fully built. Otherwise, if FDDEBUG is enabled, the debugging output fails because it tries to read the fileName, which isn't set up yet (and should in fact always be NULL). AFAICT, this has been wrong since Berkeley. Before 96bf88d52, it would accidentally f

pgsql: Fix 'skip-empty-xacts' option in test_decoding for streaming mod

2020-11-16 Thread Amit Kapila
Fix 'skip-empty-xacts' option in test_decoding for streaming mode. In streaming mode, the transaction can be decoded in multiple streams and those streams can be interleaved with streams of other transactions. So, we can't remember the transaction's write status in the logical decoding context bec