pgsql: nbtree: Rename nbtinsert.c variables for consistency.

2020-11-17 Thread Peter Geoghegan
nbtree: Rename nbtinsert.c variables for consistency. Stop naming special area/opaque pointer variables 'lpageop' in contexts where it doesn't make sense. This is a holdover from a time when logic that performs tasks that are now spread across _bt_insertonpg(), _bt_findinsertloc(), and _bt_split(

pgsql: indexcmds.c: reorder function prototypes

2020-11-17 Thread Alvaro Herrera
indexcmds.c: reorder function prototypes ... out of an overabundance of neatnikism, perhaps. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7684b6fbed3a0770a0d8fdcbb5cf8b61394de691 Modified Files -- src/backend/commands/indexcmds.c | 7 +++ 1 file c

pgsql: Deprecate nbtree's BTP_HAS_GARBAGE flag.

2020-11-17 Thread Peter Geoghegan
Deprecate nbtree's BTP_HAS_GARBAGE flag. Streamline handling of the various strategies that we have to avoid a page split in nbtinsert.c. When it looks like a leaf page is about to overflow, we now perform deleting LP_DEAD items and deduplication in one central place. This greatly simplifies _bt

pgsql: Add tab completion for CREATE [OR REPLACE] TRIGGER in psql

2020-11-17 Thread Michael Paquier
Add tab completion for CREATE [OR REPLACE] TRIGGER in psql 92bf7e2 has added support for this grammar. Author: Noriyoshi Shinoda Discussion: https://postgr.es/m/tu4pr8401mb115244623cf4724dca0d507fee...@tu4pr8401mb1152.namprd84.prod.outlook.com Branch -- master Details --- https://git.p

pgsql: Add more tests for hashing and hash-based plans

2020-11-17 Thread Peter Eisentraut
Add more tests for hashing and hash-based plans - Test hashing of an array of a non-hashable element type. - Test UNION [DISTINCT] with hash- and sort-based plans. (Previously, only INTERSECT and EXCEPT where tested there.) - Test UNION [DISTINCT] with a non-hashable column type. This curr