pgsql: Remove incorrect assertion in reorderbuffer.c.

2020-12-04 Thread Amit Kapila
Remove incorrect assertion in reorderbuffer.c. We start recording changes in ReorderBufferTXN even before we reach SNAPBUILD_CONSISTENT state so that if the commit is encountered after reaching that we should be able to send the changes of the entire transaction. Now, while recording changes if th

pgsql: Remove unnecessary grammar symbols

2020-12-04 Thread Peter Eisentraut
Remove unnecessary grammar symbols Instead of publication_name_list, we can use name_list. We already refer to publications everywhere else by the 'name' or 'name_list' symbols, so this only improves consistency. Reviewed-by: https://www.postgresql.org/message-id/flat/3e3ccddb-41bd-ecd8-29fe-19

pgsql: Convert elog(LOG) calls to ereport() where appropriate

2020-12-04 Thread Peter Eisentraut
Convert elog(LOG) calls to ereport() where appropriate User-visible log messages should go through ereport(), so they are subject to translation. Many remaining elog(LOG) calls are really debugging calls. Reviewed-by: Alvaro Herrera Reviewed-by: Michael Paquier Reviewed-by: Noah Misch Discuss

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u

pgsql: Fix race conditions in newly-added test.

2020-12-04 Thread Heikki Linnakangas
Fix race conditions in newly-added test. Buildfarm has been failing sporadically on the new test. I was able to reproduce this by adding a random 0-10 s delay in the walreceiver, just before it connects to the primary. There's a race condition where node_3 is promoted before it has fully caught u