Re: pgsql: Add pg_alterckey utility to change the cluster key

2020-12-27 Thread Michael Paquier
On Sat, Dec 26, 2020 at 02:00:02PM -0500, Bruce Momjian wrote: > On Sat, Dec 26, 2020 at 12:18:18PM -0500, Bruce Momjian wrote: >> I can easily revert and come back, though the buildfarm is green now. >> As far as testing, I can test that the cluster key unlocks the data >> keys, but there is no c

Re: pgsql: Add pg_alterckey utility to change the cluster key

2020-12-27 Thread Bruce Momjian
On Sun, Dec 27, 2020 at 05:48:47PM +0900, Michael Paquier wrote: > On Sat, Dec 26, 2020 at 02:00:02PM -0500, Bruce Momjian wrote: > > On Sat, Dec 26, 2020 at 12:18:18PM -0500, Bruce Momjian wrote: > >> I can easily revert and come back, though the buildfarm is green now. > >> As far as testing, I

pgsql: Stabilize test introduced in 05c02589, per buildfarm.

2020-12-27 Thread Jeff Davis
Stabilize test introduced in 05c02589, per buildfarm. In passing, make the capitalization match the rest of the file. Reported-by: Tom Lane Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fa0fdf0510df1a21f42ac9f232f77a79b8577152 Modified Files -- src/t

Re: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.

2020-12-27 Thread Jeff Davis
On Sun, 2020-12-27 at 02:09 -0500, Tom Lane wrote: > Jeff Davis writes: > > Fix bug #16784 in Disk-based Hash Aggregation. > > Buildfarm thinks this new test case is not completely stable. > > It appears that only 32-bit machines are failing, and it's > not totally consistent even for them. Dun

pgsql: Second attempt to stabilize 05c02589.

2020-12-27 Thread Jeff Davis
Second attempt to stabilize 05c02589. Removing the EXPLAIN test to stabilize the buildfarm. The execution test should still be effective to catch the bug even if the plan is slightly different on different platforms. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f

pgsql: Second attempt to stabilize 05c02589.

2020-12-27 Thread Jeff Davis
Second attempt to stabilize 05c02589. Removing the EXPLAIN test to stabilize the buildfarm. The execution test should still be effective to catch the bug even if the plan is slightly different on different platforms. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Stabilize test introduced in 05c02589, per buildfarm.

2020-12-27 Thread Jeff Davis
Stabilize test introduced in 05c02589, per buildfarm. In passing, make the capitalization match the rest of the file. Reported-by: Tom Lane Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6669cc769c44b691510c14be12acd9148c74d4d1 Modified Files -

Re: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.

2020-12-27 Thread Jeff Davis
On Sun, 2020-12-27 at 09:59 -0800, Jeff Davis wrote: > I think I just need to disable sort. Because there is a () group, we > don't need a Sort in the plan to exercise the bug. That still didn't stabilize the test, so I removed the EXPLAIN part of the test and left the execution test in place. Th

pgsql: Revert "Add key management system" (978f869b99) & later commits

2020-12-27 Thread Bruce Momjian
Revert "Add key management system" (978f869b99) & later commits The patch needs test cases, reorganization, and cfbot testing. Technically reverts commits 5c31afc49d..e35b2bad1a (exclusive/inclusive) and 08db7c63f3..ccbe34139b. Reported-by: Tom Lane, Michael Paquier Discussion: https://postgr.es

Re: pgsql: Add pg_alterckey utility to change the cluster key

2020-12-27 Thread Bruce Momjian
On Sun, Dec 27, 2020 at 12:44:50PM -0500, Bruce Momjian wrote: > > Based on the number of concerns raised by various people over the last > > couple of days (including myself, one point being the refactoring of > > the ciphers taken from pgcrypto that should have been in its own > > commit), I agre