pgsql: Remove duplicate include

2021-01-25 Thread Peter Eisentraut
Remove duplicate include Reported-by: Ashutosh Sharma Discussion: https://www.postgresql.org/message-id/flat/CAE9k0PkORqHHGKY54-sFyDpP90yAf%2B05Auc4fs9EAn4J%2BuBeUQ%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ecc4b1318c92594abdf9bd2933fb6feaa9

pgsql: Doc: improve documentation of pg_proc.protrftypes.

2021-01-25 Thread Tom Lane
Doc: improve documentation of pg_proc.protrftypes. Add a "references" link pointing to pg_type, as we have for other arrays of type OIDs. Wordsmith the explanation a bit. Joel Jacobson, additional editing by me Discussion: https://postgr.es/m/d1cc628c-3953-4209-957b-29427acc3...@www.fastmail.c

pgsql: Doc: improve documentation of pg_proc.protrftypes.

2021-01-25 Thread Tom Lane
Doc: improve documentation of pg_proc.protrftypes. Add a "references" link pointing to pg_type, as we have for other arrays of type OIDs. Wordsmith the explanation a bit. Joel Jacobson, additional editing by me Discussion: https://postgr.es/m/d1cc628c-3953-4209-957b-29427acc3...@www.fastmail.c

pgsql: Remove CheckpointLock.

2021-01-25 Thread Robert Haas
Remove CheckpointLock. Up until now, we've held this lock when performing a checkpoint or restartpoint, but commit 076a055acf3c55314de267c62b03191586d79cf6 back in 2004 and commit 7e48b77b1cebb9a43f9fdd6b17128a0ba36132f9 from 2009, taken together, have removed all need for this. In the present cod

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Fix broken ruleutils support for function TRANSFORM clauses.

2021-01-25 Thread Tom Lane
Fix broken ruleutils support for function TRANSFORM clauses. I chanced to notice that this dumped core due to a faulty Assert. To add insult to injury, the output has been misformatted since v11. Obviously we need some regression testing here. Discussion: https://postgr.es/m/d1cc628c-3953-4209-9

pgsql: Don't clobber the calling user's credentials cache in Kerberos t

2021-01-25 Thread Tom Lane
Don't clobber the calling user's credentials cache in Kerberos test. Embarrassing oversight in this test script, which fortunately is not run by default. Report and patch by Jacob Champion. Discussion: https://postgr.es/m/1fcb175bafef6560f47a8c31229fa7c938486b8d.ca...@vmware.com Branch --

pgsql: Don't clobber the calling user's credentials cache in Kerberos t

2021-01-25 Thread Tom Lane
Don't clobber the calling user's credentials cache in Kerberos test. Embarrassing oversight in this test script, which fortunately is not run by default. Report and patch by Jacob Champion. Discussion: https://postgr.es/m/1fcb175bafef6560f47a8c31229fa7c938486b8d.ca...@vmware.com Branch --

pgsql: Don't clobber the calling user's credentials cache in Kerberos t

2021-01-25 Thread Tom Lane
Don't clobber the calling user's credentials cache in Kerberos test. Embarrassing oversight in this test script, which fortunately is not run by default. Report and patch by Jacob Champion. Discussion: https://postgr.es/m/1fcb175bafef6560f47a8c31229fa7c938486b8d.ca...@vmware.com Branch --

pgsql: Don't clobber the calling user's credentials cache in Kerberos t

2021-01-25 Thread Tom Lane
Don't clobber the calling user's credentials cache in Kerberos test. Embarrassing oversight in this test script, which fortunately is not run by default. Report and patch by Jacob Champion. Discussion: https://postgr.es/m/1fcb175bafef6560f47a8c31229fa7c938486b8d.ca...@vmware.com Branch --

pgsql: Fix two typos in snapbuild.c.

2021-01-25 Thread Andres Freund
Fix two typos in snapbuild.c. Reported-by: Heikki Linnakangas Discussion: https://postgr.es/m/c94be044-818f-15e3-1ad3-7a7ae2dfe...@iki.fi Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/55ef8555f0c1207bac25050e7297bbb969c84233 Modified Files -- src/bac

pgsql: Improve performance of repeated CALLs within plpgsql procedures.

2021-01-25 Thread Tom Lane
Improve performance of repeated CALLs within plpgsql procedures. This patch essentially is cleaning up technical debt left behind by the original implementation of plpgsql procedures, particularly commit d92bc83c4. That patch (or more precisely, follow-on patches fixing its worst bugs) forced us

pgsql: postgres_fdw: Add functions to discard cached connections.

2021-01-25 Thread Fujii Masao
postgres_fdw: Add functions to discard cached connections. This commit introduces two new functions postgres_fdw_disconnect() and postgres_fdw_disconnect_all(). The former function discards the cached connections to the specified foreign server. The latter discards all the cached connections. If t

Re: pgsql: postgres_fdw: Add functions to discard cached connections.

2021-01-25 Thread Fujii Masao
On 2021/01/26 15:37, Fujii Masao wrote: postgres_fdw: Add functions to discard cached connections. This commit introduces two new functions postgres_fdw_disconnect() and postgres_fdw_disconnect_all(). The former function discards the cached connections to the specified foreign server. The lat

pgsql: postgres_fdw: Stabilize regression test for postgres_fdw_disconn

2021-01-25 Thread Fujii Masao
postgres_fdw: Stabilize regression test for postgres_fdw_disconnect_all(). The regression test added in commit 411ae64997 caused buildfarm failures. The cause of them was that the order of warning messages output in the test was not stable. To fix this, this commit sets client_min_messages to ERRO