Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-08-01 Thread Etsuro Fujita
On Sun, Aug 1, 2021 at 1:41 AM Tom Lane wrote: > I tried this patch on a spare machine that seems prone to showing > the failure: on HEAD, postgres_fdw's installcheck failed 3 times > in 4 attempts. With the patch, it's gotten through 23 consecutive > tries without a failure. So this is at least

Re: pgsql: Enable TAP tests of pg_receivewal for ZLIB on Windows, take thre

2021-08-01 Thread Andrew Dunstan
On 7/31/21 11:32 PM, Michael Paquier wrote: > On Sat, Jul 31, 2021 at 07:16:22AM -0400, Andrew Dunstan wrote: >> And now jacana is unhappy. I'll get it fixed shortly. If it ends up that >> we have somehow found a situation where Msys/Mingw and MSVC can no >> longer share a zlib implementation I'm

pgsql: Silence perl warning about uninitialized value

2021-08-01 Thread Andrew Dunstan
Silence perl warning about uninitialized value Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d1401931868e03342ed4689b5af2522eb40f750 Modified Files -- src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix test failure in 021_twophase.pl.

2021-08-01 Thread Amit Kapila
Fix test failure in 021_twophase.pl. The test is expecting two prepared transactions corresponding to two subscriptions but it waits to catch up for just one subscription. Fix it by allowing to wait for both subscriptions. Reported-by: Michael Paquier, as per buildfarm Author: Ajin Cherian Review

pgsql: Fix oversight in commit 1ec7fca8592178281cd5cdada0f27a340fb813fc

2021-08-01 Thread Etsuro Fujita
Fix oversight in commit 1ec7fca8592178281cd5cdada0f27a340fb813fc. I failed to account for the possibility that when ExecAppendAsyncEventWait() notifies multiple async-capable nodes using postgres_fdw, a preceding node might invoke process_pending_request() to process a pending asynchronous request

pgsql: Fix oversight in commit 1ec7fca8592178281cd5cdada0f27a340fb813fc

2021-08-01 Thread Etsuro Fujita
Fix oversight in commit 1ec7fca8592178281cd5cdada0f27a340fb813fc. I failed to account for the possibility that when ExecAppendAsyncEventWait() notifies multiple async-capable nodes using postgres_fdw, a preceding node might invoke process_pending_request() to process a pending asynchronous request

Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.

2021-08-01 Thread Etsuro Fujita
On Sun, Aug 1, 2021 at 4:59 PM Etsuro Fujita wrote: > But I plan on applying the patch tomorrow. Done, in hopes of making the buildfarm back to green. Best regards, Etsuro Fujita

pgsql: Remove misplaced comment from AuxiliaryProcessMain().

2021-08-01 Thread Andres Freund
Remove misplaced comment from AuxiliaryProcessMain(). The comment didn't make sense anymore since at least 626eb021988. As it didn't actually explain anything anyway, just remove it. Author: Andres Freund Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8b1de88b7ce

pgsql: Run checkpointer and bgwriter in crash recovery.

2021-08-01 Thread Thomas Munro
Run checkpointer and bgwriter in crash recovery. Start up the checkpointer and bgwriter during crash recovery (except in --single mode), as we do for replication. This wasn't done back in commit cdd46c76 out of caution. Now it seems like a better idea to make the environment as similar as possib