Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-22 Thread Michael Paquier
On Wed, Sep 22, 2021 at 11:01:05AM +0900, Michael Paquier wrote: > 1a9d8028 should have taken care of the problem. Thanks for the > report. jacana has reported green after this commit, and the test has passed with Msys. So we are done here. -- Michael signature.asc Description: PGP signature

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-22 Thread Andres Freund
On 2021-09-22 11:01:05 +0900, Michael Paquier wrote: > On Tue, Sep 21, 2021 at 03:12:02PM +0900, Michael Paquier wrote: > > Thanks. I'll group this stuff with what I still need to do for Msys. > > This just needs to wait until RC1 is tagged as I need to address the > > existing issues in TestLib.p

pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d

2021-09-22 Thread Fujii Masao
postgres_fdw: Refactor transaction rollback code to avoid code duplication. In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback() callback functions do almost the same thing to rollback remote toplevel- and sub-transaction. But previously their such rollback logics were implemented s

pgsql: Document issue with heapam line pointer truncation.

2021-09-22 Thread Peter Geoghegan
Document issue with heapam line pointer truncation. Checking that an offset number isn't past the end of a heap page's line pointer array was just a defensive sanity check for HOT-chain traversal code before commit 3c3b8a4b. It's etrictly necessary now, though. Add comments that reference the is