pgsql: pg_dump: Add missing relkind case

2021-12-02 Thread Peter Eisentraut
pg_dump: Add missing relkind case Checking for RELKIND_MATVIEW was forgotten in guessConstraintInheritance(). This isn't a live problem, since it is checked in flagInhTables() which relkinds can have parents, and those entries will have numParents==0 after that. But after discussion it was felt

Re: pgsql: psql: initialize comment-begin setting to a useful value by defa

2021-12-02 Thread Tom Lane
Michael Paquier writes: > On Wed, Dec 01, 2021 at 05:24:58PM +, Tom Lane wrote: >> psql: initialize comment-begin setting to a useful value by default. > prairiedog is unhappy after this commit due to the use of > rl_variable_bind(): Meh. Guess we need a configure probe for rl_variable_bind

pgsql: Add configure probe for rl_variable_bind().

2021-12-02 Thread Tom Lane
Add configure probe for rl_variable_bind(). Some exceedingly ancient readline libraries lack this function, causing commit 3d858af07 to fail. Per buildfarm (via Michael Paquier). Discussion: https://postgr.es/m/e1mstlm-0007cm...@gemulon.postgresql.org Branch -- master Details --- https

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Andres Freund
Hi, On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: > Looks like perl2host() was the missing piece, fairywren turned green with > commit c3b34a0ff4. Does that work with MSVC? I rebased my CI patch ontop of this, and it fails on windows: https://cirrus-ci.com/task/6093088335593472?logs=ssl_

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Andrew Dunstan
On 12/2/21 14:51, Andres Freund wrote: > Hi, > > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: >> Looks like perl2host() was the missing piece, fairywren turned green with >> commit c3b34a0ff4. > Does that work with MSVC? I rebased my CI patch ontop of this, and it fails on > windows: >

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Daniel Gustafsson
> On 2 Dec 2021, at 20:51, Andres Freund wrote: > > Hi, > > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: >> Looks like perl2host() was the missing piece, fairywren turned green with >> commit c3b34a0ff4. > > Does that work with MSVC? I rebased my CI patch ontop of this, and it fails o

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Andres Freund
Hi, On 2021-12-02 15:59:44 -0500, Andrew Dunstan wrote: > On 12/2/21 14:51, Andres Freund wrote: > > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: > >> Looks like perl2host() was the missing piece, fairywren turned green with > >> commit c3b34a0ff4. > > Does that work with MSVC? I rebased

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Andres Freund
Hi, On 2021-12-02 22:07:17 +0100, Daniel Gustafsson wrote: > > On 2 Dec 2021, at 20:51, Andres Freund wrote: > > > > Hi, > > > > On 2021-12-01 20:49:21 +0100, Daniel Gustafsson wrote: > >> Looks like perl2host() was the missing piece, fairywren turned green with > >> commit c3b34a0ff4. > > > >

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

pgsql: On Windows, close the client socket explicitly during backend sh

2021-12-02 Thread Tom Lane
On Windows, close the client socket explicitly during backend shutdown. It turns out that this is necessary to keep Winsock from dropping any not-yet-sent data, such as an error message explaining the reason for process termination. It's pretty weird that the implicit close done by the kernel act

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Daniel Gustafsson
> On 2 Dec 2021, at 22:21, Andres Freund wrote: > And this works because it uses *forward* slashes instad of backward slashes, > which then do not get escaped by the guc machinery. Correct. Applying the same fix to the src/test/ssl/t/00X (per the attached) makes the ssl tests pass in MSVC when

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Andres Freund
Hi, On 2021-12-02 23:34:06 +0100, Daniel Gustafsson wrote: > > On 2 Dec 2021, at 22:21, Andres Freund wrote: > > > And this works because it uses *forward* slashes instad of backward slashes, > > which then do not get escaped by the guc machinery. > > Correct. Applying the same fix to the src/

Re: pgsql: Add TAP tests for contrib/sslinfo

2021-12-02 Thread Daniel Gustafsson
> On 2 Dec 2021, at 23:54, Andres Freund wrote: > > Hi, > > On 2021-12-02 23:34:06 +0100, Daniel Gustafsson wrote: >>> On 2 Dec 2021, at 22:21, Andres Freund wrote: >> >>> And this works because it uses *forward* slashes instad of backward slashes, >>> which then do not get escaped by the guc

pgsql: Improve the description of various GUCs

2021-12-02 Thread Michael Paquier
Improve the description of various GUCs This commit fixes a couple of inconsistencies in the descriptions of some GUCs, while making their wording more general regarding the units they rely on. For most of them, this removes the use of terms like "N seconds" or "N bytes", which may not apply easi