Re: pgsql: Check that we have a working tar before trying to use it

2021-12-09 Thread Tom Lane
Michael Paquier writes: > ... I got some copies of tar.exe lying > around, one from a git installation and a second one from Msys, but > both don't work even if $ENV{TAR} points at them :/ What goes wrong exactly? The test I proposed ("tar cf foo.tar foo") doesn't seem like it will catch the ac

Re: pgsql: Check that we have a working tar before trying to use it

2021-12-09 Thread Andrew Dunstan
On 12/8/21 21:16, Andres Freund wrote: > Hi, > > On 2021-12-08 12:53:29 -0500, Andrew Dunstan wrote: >> It would have passed the test and failed the invocation as before. It >> turns out that the tar being used is from the (old) MsysGit >> installation. So I'm rearranging the path so it finds the

Re: pgsql: Check that we have a working tar before trying to use it

2021-12-09 Thread Andrew Dunstan
On 12/9/21 02:10, Michael Paquier wrote: > On Wed, Dec 08, 2021 at 10:49:28PM -0800, Andres Freund wrote: >> Could you expand on why it doesn't work? As far as I can tell tar is shipped >> with windows these days, and %SYSTEMROOT%/system32/tar.exe should point to >> that tar? > FWIW, my Windows 1

pgsql: Check for STATUS_DELETE_PENDING on Windows.

2021-12-09 Thread Thomas Munro
Check for STATUS_DELETE_PENDING on Windows. 1. Update our open() wrapper to check for NT's STATUS_DELETE_PENDING and translate it to Unix-like errors. This is done with RtlGetLastNtStatus(), which is dynamically loaded from ntdll. A new file win32ntdll.c centralizes lookup of NT functions, in c