pgsql: pg_dump: Refactor dumpDatabase()

2022-01-04 Thread Peter Eisentraut
pg_dump: Refactor dumpDatabase() Rearrange the version-dependent pieces in the new more modular style. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/56a3e848c74730cde15278266b757f4262948763 Modified Files -- src/bin/pg_dump/pg_dump.c | 39

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Allow special SKIP LOCKED condition in Assert()

2022-01-04 Thread Alvaro Herrera
Allow special SKIP LOCKED condition in Assert() Under concurrency, it is possible for two sessions to be merrily locking and releasing a tuple and marking it again as HEAP_XMAX_INVALID all the while a third session attempts to lock it, miserably fails at it, and then contemplates life, the univers

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/67a8cb5cbfffa9f104a5965a2152e5256dd2be2c Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/33fdd9f854f8db263d96e2916aa67325b8b26992 Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b63851a45635299929301a849327c392da3c1a34 Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f9db153c282de599a7d5ae2694f50fe10fba8461 Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/397b43948861155893da0f04b4de8e7ff021636f Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Fix silly mistake in Assert

2022-01-04 Thread Alvaro Herrera
Fix silly mistake in Assert Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4a8282425f6b6db19a07dcb634b5a670d0289c95 Modified Files -- src/backend/access/heap/heapam.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Remove redundant initialization of BrinMemTuple.

2022-01-04 Thread Tom Lane
Remove redundant initialization of BrinMemTuple. brin_new_memtuple already did this, so there's no need for initialize_brin_buildstate to do it again. Richard Guo, reviewed by Bharath Rupireddy Discussion: https://postgr.es/m/CAMbWs4-kYYpKNOdiWtsCZ3jbkFFj4nhOVH22JH7dsrMYX=a...@mail.gmail.com B

pgsql: Reduce relcache access in WAL sender streaming logical changes

2022-01-04 Thread Michael Paquier
Reduce relcache access in WAL sender streaming logical changes get_rel_sync_entry(), which is called each time a change needs to be logically replicated, is a rather hot code path in the WAL sender sending logical changes. This code path was doing a relcache access on relkind and relpartition for

pgsql: Reduce relcache access in WAL sender streaming logical changes

2022-01-04 Thread Michael Paquier
Reduce relcache access in WAL sender streaming logical changes get_rel_sync_entry(), which is called each time a change needs to be logically replicated, is a rather hot code path in the WAL sender sending logical changes. This code path was doing a relcache access on relkind and relpartition for

pgsql: Reduce relcache access in WAL sender streaming logical changes

2022-01-04 Thread Michael Paquier
Reduce relcache access in WAL sender streaming logical changes get_rel_sync_entry(), which is called each time a change needs to be logically replicated, is a rather hot code path in the WAL sender sending logical changes. This code path was doing a relcache access on relkind and relpartition for