pgsql: Enable routine running of citext's UTF8-specific test cases.

2022-01-05 Thread Tom Lane
Enable routine running of citext's UTF8-specific test cases. These test cases have been commented out since citext was invented, because at the time we had no nice way to deal with tests that have restrictions such as requiring UTF8 encoding. But now we do have a convention for that, ie put them

pgsql: Create foreign key triggers in partitioned tables too

2022-01-05 Thread Alvaro Herrera
Create foreign key triggers in partitioned tables too While user-defined triggers defined on a partitioned table have a catalog definition for both it and its partitions, internal triggers used by foreign keys defined on partitioned tables only have a catalog definition for its partitions. This c

pgsql: Enable routine running of regex.linux.utf8 regression test.

2022-01-05 Thread Tom Lane
Enable routine running of regex.linux.utf8 regression test. Up to now this has just sat there as a test you could invoke via EXTRA_TESTS, which of course nobody does. I'm feeling encouraged because c2e8bd275 hasn't yet broke anything, so let's try making this run with a suitable guard condition (

Re: pgsql: Create foreign key triggers in partitioned tables too

2022-01-05 Thread Tom Lane
Alvaro Herrera writes: > This also changes what tgisinternal means in some cases. Currently, > it means either that the trigger is an internal implementation object > of a foreign key constraint, or a "child" trigger on a partition > cloned from the trigger on the parent. This commit changes it

pgsql: On second thought, remove regex.linux.utf8 regression test altog

2022-01-05 Thread Tom Lane
On second thought, remove regex.linux.utf8 regression test altogether. The code-coverage report says that this test doesn't increase coverage by one single line, which I now realize is because I made src/test/modules/test_regex/sql/test_regex_utf8.sql to cover all the code that this would. So rea

pgsql: doc: Remove link to JSON support in the SQL specification

2022-01-05 Thread Michael Paquier
doc: Remove link to JSON support in the SQL specification The link used in the documentation is dead, and the only options to have an access to this part of the SQL specification are not free. Like any other books referred, just remove the link to keep some neutrality but keep its reference. Rep

pgsql: doc: Remove link to JSON support in the SQL specification

2022-01-05 Thread Michael Paquier
doc: Remove link to JSON support in the SQL specification The link used in the documentation is dead, and the only options to have an access to this part of the SQL specification are not free. Like any other books referred, just remove the link to keep some neutrality but keep its reference. Rep

pgsql: doc: Remove link to JSON support in the SQL specification

2022-01-05 Thread Michael Paquier
doc: Remove link to JSON support in the SQL specification The link used in the documentation is dead, and the only options to have an access to this part of the SQL specification are not free. Like any other books referred, just remove the link to keep some neutrality but keep its reference. Rep

pgsql: doc: Remove link to JSON support in the SQL specification

2022-01-05 Thread Michael Paquier
doc: Remove link to JSON support in the SQL specification The link used in the documentation is dead, and the only options to have an access to this part of the SQL specification are not free. Like any other books referred, just remove the link to keep some neutrality but keep its reference. Rep