pgsql: Change collate and ctype fields to type text

2022-01-27 Thread Peter Eisentraut
Change collate and ctype fields to type text This changes the data type of the catalog fields datcollate, datctype, collcollate, and collctype from name to text. There wasn't ever a really good reason for them to be of type name; presumably this was just carried over from when they were fixed-siz

pgsql: psql: Add tab completion for ALTER COLLATION / REFRESH VERSION

2022-01-27 Thread Peter Eisentraut
psql: Add tab completion for ALTER COLLATION / REFRESH VERSION This was forgotten when this command form was added (eccfef81e1f73ee41f1d8bfe4fa4e80576945048). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fefce9ef987ea00cd963f679223fdb9d381b9ec5 Modified Files --

pgsql: Improve msys2 detection for TAP tests

2022-01-27 Thread Andrew Dunstan
Improve msys2 detection for TAP tests Perl instances on some msys toolchains (e.g. UCRT64) have their configured osname set to 'MSWin32' rather than 'msys'. The test for the msys2 platform is adjusted accordingly. Backpatch to release 14. Branch -- REL_14_STABLE Details --- https://git

pgsql: Improve msys2 detection for TAP tests

2022-01-27 Thread Andrew Dunstan
Improve msys2 detection for TAP tests Perl instances on some msys toolchains (e.g. UCRT64) have their configured osname set to 'MSWin32' rather than 'msys'. The test for the msys2 platform is adjusted accordingly. Backpatch to release 14. Branch -- master Details --- https://git.postgr

pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
pg_basebackup: Fix a couple of recently-introduced bugs. The server expects the compression level to be between 1 and 9, but Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value to the server. Because pg_basebackup's -R option is implemented on the client side, it can't be used in c

pgsql: Remove some trailing whitespace in documentation files

2022-01-27 Thread Peter Eisentraut
Remove some trailing whitespace in documentation files Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c9cfc861fc871014f9f2fce477c8182fa13fc120 Modified Files -- doc/src/sgml/hash.sgml| 4 ++-- doc/src/sgml/ref/alter_collation.sgml | 2 +-

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 04:15:45PM +, Robert Haas wrote: > pg_basebackup: Fix a couple of recently-introduced bugs. > > The server expects the compression level to be between 1 and 9, but > Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value > to the server. If I'm not wrong, t

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > If I'm not wrong, this is causing failures on cfbot. > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > [17:24:48.348] c:\cirrus\src\backend\replication\basebackup_gzip.c(90): > warning C4715: 'bbsink_gzip_new': not all contr

pgsql: Fix ordering of XIDs in ProcArrayApplyRecoveryInfo

2022-01-27 Thread Tomas Vondra
Fix ordering of XIDs in ProcArrayApplyRecoveryInfo Commit 8431e296ea reworked ProcArrayApplyRecoveryInfo to sort XIDs before adding them to KnownAssignedXids. But the XIDs are sorted using xidComparator, which compares the XIDs simply as uint32 values, not logically. KnownAssignedXidsAdd() however

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote: > On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > > If I'm not wrong, this is causing failures on cfbot. > > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056 > > > > [17:24:48.348] c:\cirrus\src\backend\replication\ba

pgsql: pg_basebackup: Add a dummy return to bbsink_gzip_new().

2022-01-27 Thread Robert Haas
pg_basebackup: Add a dummy return to bbsink_gzip_new(). Apparently, this is needed to avoid warnings on MVCC. David Rowley Discussion: http://postgr.es/m/CAApHDvosHkgyo_PZs7CSB4Kgs2ey4FdmFpcK0N_QOci9DJ=w...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/comm

Re: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

2022-01-27 Thread Robert Haas
On Thu, Jan 27, 2022 at 2:22 PM Justin Pryzby wrote: > On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote: > > On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote: > > > If I'm not wrong, this is causing failures on cfbot. > > > https://cirrus-ci.com/task/6312181619752960?logs=build#L20

pgsql: Avoid referencing Z_DEFAULT_COMPRESSION outside HAVE_LIBZ.

2022-01-27 Thread Robert Haas
Avoid referencing Z_DEFAULT_COMPRESSION outside HAVE_LIBZ. Because that's bad. Discussion: http://postgr.es/m/20220127174545.gv23...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8ee940843dfed6623b0a0d0b15080aa469116ce0 Modified Files -

pgsql: Specify --host in 027_stream_regress.pl's pg_regress invocation.

2022-01-27 Thread Andres Freund
Specify --host in 027_stream_regress.pl's pg_regress invocation. The invocation of pg_regress in 027_stream_regress.pl didn't specify the host. It ends up working on most systems because of connection defaults. However, on windows it makes the test very slow unless PG_TEST_USE_UNIX_SOCKETS is used

pgsql: Prevent memory context logging from sending log message to conne

2022-01-27 Thread Fujii Masao
Prevent memory context logging from sending log message to connected client. When pg_log_backend_memory_contexts() is executed, the target backend should use LOG_SERVER_ONLY to log its memory contexts, to prevent them from being sent to its connected client regardless of client_min_messages. But p

pgsql: Prevent memory context logging from sending log message to conne

2022-01-27 Thread Fujii Masao
Prevent memory context logging from sending log message to connected client. When pg_log_backend_memory_contexts() is executed, the target backend should use LOG_SERVER_ONLY to log its memory contexts, to prevent them from being sent to its connected client regardless of client_min_messages. But p

pgsql: Fix typo in comment.

2022-01-27 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d99166ed4f6e9f370289a90dd6678c06bfffd41f Modified Files -- src/backend/executor/nodeForeignscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-01-27 Thread Etsuro Fujita
Fix typo in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eabcfd99ed27e5d21fee91fc7007678589081f58 Modified Files -- src/backend/executor/nodeForeignscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Update ALTER COLLATION wording

2022-01-27 Thread Peter Eisentraut
doc: Update ALTER COLLATION wording The original text on refreshing collation versions was written specifically for ICU, and then information for other providers was incrementally tacked on at the end. Reword this to be a bit more general and less reflective of how it was added. Branch -- ma