Re: pgsql: Split xlog.c into xlog.c and xlogrecovery.c.

There are some segfaults in the buildfarm because of this, eg: Program terminated with signal 11, Segmentation fault. Error while reading shared library symbols: Dwarf Error: wrong version in compilation unit header (is 4, should be 2) [in module /usr/libexec/ld.so] #0 memcpy (dst0=Variable "d

pgsql: Reject trailing junk after numeric literals

Reject trailing junk after numeric literals After this, the PostgreSQL lexers no longer accept numeric literals with trailing non-digits, such as 123abc, which would be scanned as two tokens: 123 and abc. This is undocumented and surprising, and it might also interfere with some extended numeric

pgsql: Fix read beyond buffer bug introduced by the split xlog.c patch.

Fix read beyond buffer bug introduced by the split xlog.c patch. FinishWalRecovery() copied the valid part of the last WAL block into a palloc'd buffer, and the code in StartupXLOG() copied it to the WAL buffer. But the memcpy in StartupXLOG() copied a full 8kB block, not just the valid part, i.e.

pgsql: Add missing TYPEALIGN macros

Add missing TYPEALIGN macros A couple call sites still had hard-coded characters. Amul Sul Discussion: https://www.postgresql.org/message-id/CAAJ_b94Y35MWB3PJoCbc_O-_Q4%2B-9DHKhWtAwboEyx8wm4mqcA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/01a

Re: pgsql: Remove IS_AF_UNIX macro

On 15.02.22 16:41, Tom Lane wrote: Peter Eisentraut writes: Remove IS_AF_UNIX macro The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS, apparently since 2008. I hadn't looked closely at this patch, but are you referring to this bit in ip.h? #ifdef HAVE_UNIX_SOCKETS #define

Re: pgsql: Remove IS_AF_UNIX macro

Peter Eisentraut writes: > On 15.02.22 16:41, Tom Lane wrote: >> I hadn't looked closely at this patch, but are you referring to >> this bit in ip.h? > In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that > has been there unprotected by any #ifdef since about 2008. Oh, I see it

pgsql: Fix bogus log message when starting from a cleanly shut down sta

Fix bogus log message when starting from a cleanly shut down state. In commit 70e81861fa to split xlog.c, I moved the startup code that updates the state in the control file and prints out the "database system was not properly shut down" message to the log, but I accidentally removed the "if (InRe

pgsql: Remove all traces of tuplestore_donestoring() in the C code

Remove all traces of tuplestore_donestoring() in the C code This routine is a no-op since dd04e95 from 2003, with a macro kept around for compatibility purposes. This has led to the same code patterns being copy-pasted around for no effect, sometimes in confusing ways like in pg_logical_slot_get_

pgsql: Avoid VACUUM reltuples distortion.

Avoid VACUUM reltuples distortion. Add a heuristic that avoids distortion in the pg_class.reltuples estimates used by VACUUM. Without the heuristic, successive manually run VACUUM commands (run against a table that is never modified after initial bulk loading) will scan the same page in each VACU

pgsql: Increase hash_mem_multiplier default to 2.0.

Increase hash_mem_multiplier default to 2.0. Double the default setting for hash_mem_multiplier, from 1.0 to 2.0. This setting makes hash-based executor nodes use twice the usual work_mem limit. The PostgreSQL 15 release notes should have a compatibility note about this change. Author: Peter Geo

pgsql: plpython: Reject Python 2 during build configuration.

plpython: Reject Python 2 during build configuration. Python 2.7 went EOL 2020-01-01 and the support for Python 2 requires a fair bit of infrastructure. Therefore we are removing Python 2 support in plpython. This patch just rejects Python 2 during configure / mkvcbuild.pl. Future commits will re